Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
1784002	Fix the scope on the initialization of kMicrodumpOnConsole to match header. (Closed)	primiano	Mark Mentovai, casinobong88, toi481982		9 years, 11 months
6844002	Fix signal propagation logic for Linux/Android exception handler. (Closed)	primiano	Mark Mentovai	1	9 years, 11 months
2864002	Microdump processor: be more tolerant for different logcat formats (Closed)	primiano	mmandlis		9 years, 11 months
9794002	[microdump] Add build fingerprint and product info metadata.	primiano	Lei Zhang (chromium), Mark Mentovai, mmandlis	8	10 years
587002	Use dynamic linker provided information to fill library mappings in linux minidumps, when possible	glandium	Ted Mielczarek, clairetom80	3	10 years
3794002	Fix compatibility with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans	5	10 years
7814002	Make breakpad compatible with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans		10 years
10714002	Microdump writer: stop using new/malloc in compromised context (Closed)	primiano	Lei Zhang (chromium)		10 years
2734002	Fix building minidump processor and minidump tools for MinGW	j.turney	Ted Mielczarek		10 years, 2 months
6684002	Remove unneeded definitions of O_BINARY (Closed)	j.turney	Ted Mielczarek, vapier		10 years, 2 months
6724002	Fix copyright notice in dump_context.cc (Closed)	primiano	vapier		10 years, 2 months
1624002	Add flags to control the amount of information written to Linux minidump files	Pedro Navarro	Lei Zhang (chromium), Ted Mielczarek, casinobong88	17	10 years, 2 months
5744002	dump_syms: Fix handling of DW_FORM_ref_addr to work with DWARF 4 (Closed)	mseaborn	Roland McGrath, Mark Mentovai	5	10 years, 3 months
2824002	Microdumps: support aarch64 and lib mapping from APK (Closed)	primiano	mmandlis	3	10 years, 3 months
4704002	Introduce microdump_stackwalk comand line executable (Closed)	primiano	mmandlis, Mark Mentovai	6	10 years, 4 months
2814002	Fix microdump_writer and add unittest. (Closed)	primiano	mmandlis	2	10 years, 4 months
5714003	Microdump processing implementation (Closed)	mmandlis	primiano, subportt	102	10 years, 4 months
1114003	Expose ExceptionHandler::HandleSignal for use in non-breakpad signal handlers. (Closed)	Jed Davis	Ted Mielczarek		10 years, 5 months
1724002	Linux multiprocess crash reporter: use pipe instead of socketpair in the client. (Closed)	Jed Davis	Ted Mielczarek		10 years, 5 months
5754002	Introduce microdump writer class. (Closed)	primiano	mmandlis, Mark Mentovai	42	10 years, 5 months

Newer ›