Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 2734002: Fix building minidump processor and minidump tools for MinGW

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by j.turney
Modified:
2 years, 2 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Part of https://breakpad.appspot.com/548002 was commited as svn r1399 to fixed
client compilation for MinGW

This is mainly the configure.ac and Makefile.am changes left over from
https://breakpad.appspot.com/548002/ with a bit of updating, to fix building of
the minidump processor library and tools for MinGW

- Link minidump_stackwalk, minidump_dump, microdump_stackwalk with PTHREAD_LIBS
as pthread_cancel is used
- Link minidump_stackwalk, microdump_stackwalk with ws2_32 as ntoh functions are
used
- _s function variants should only be used if _MSC_VER, use _r variants with
MinGW (and define _POSIX to ensure they are prototyped)
- Don't try to include arpa/inet.h on Windows
- Provide int16_t, int64_t types

Note that a recent MinGW-w64 with a real strtok_r, rather than one emulated
using strtok is needed for the processor to work properly.

Patch Set 1 #

Patch Set 2 : Fix building minidump processor and minidump tools for MinGW #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 5 chunks +12 lines, -4 lines 0 comments Download
M configure.ac View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/google_breakpad/common/breakpad_types.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/processor/basic_source_line_resolver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/processor/binarystream.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/processor/cfi_frame_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/processor/logging.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/processor/minidump.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/processor/tokenize.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted