Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
1784002	Fix the scope on the initialization of kMicrodumpOnConsole to match header. (Closed)	primiano	Mark Mentovai, casinobong88, toi481982		10 years
6844002	Fix signal propagation logic for Linux/Android exception handler. (Closed)	primiano	Mark Mentovai	1	10 years
7834002	Support object files larger than 2**32. (Closed)	erikchen	Mark Mentovai	28	10 years
6824002	MIPS64: Initial MIPS64 related change. (Closed)	gordanac	rmcilroy, Mark Mentovai	3	10 years
3744002	[MIPS]: Use mcontext_t structure for MIPS (Closed)	gordanac	fdegans, Mark Mentovai, primiano, rmcilroy	16	10 years
6834002	Merge 1447 "Fix call to rt_sigaction" (Closed)	cjhopman	cjhopman		10 years
5784002	Merge 1447 "Fix call to rt_sigaction" (Closed)	cjhopman	cjhopman		10 years
2864002	Microdump processor: be more tolerant for different logcat formats (Closed)	primiano	mmandlis		10 years, 1 month
1794002	Add address and reason for IN_PAGE_ERROR. (Closed)	bungeman	Mark Mentovai	10	10 years, 1 month
3794002	Fix compatibility with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans	5	10 years, 1 month
7814002	Make breakpad compatible with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans		10 years, 2 months
10714002	Microdump writer: stop using new/malloc in compromised context (Closed)	primiano	Lei Zhang (chromium)		10 years, 2 months
9784002	Fix Windows dump_syms x64 linking (Closed)	Ted Mielczarek	Mark Mentovai	1	10 years, 2 months
9774002	Add stack contents output functionality to minidump_stackwalk (Closed)	hashimoto	Mark Mentovai, Ted Mielczarek	2	10 years, 2 months
7804002	WIP (Closed)	hashimoto			10 years, 2 months
9764002	Update license on convert_UTF.* to the standard Unicode license (Closed)	Mark Mentovai	Ted Mielczarek		10 years, 2 months
7794002	Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. (Closed)	Will Harris	Mark Mentovai		10 years, 2 months
3784002	Cleanup Linux debug link file handling code. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		10 years, 3 months
7774002	Handle ARM THUMB functions when removing duplicate PUBLIC entries. (Closed)	Lei Zhang (chromium)	Mark Mentovai, hashimoto, Ted Mielczarek	6	10 years, 3 months
3774002	Add unit tests for overlapping functions and externs. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		10 years, 3 months

1 - 20 Older ›