Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 3794002: Fix compatibility with Android NDK r10d. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by primiano
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy, fdegans
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix compatibility with Android NDK r10d.

This is a reland of the previous CL (r1433). r1433 did not achieve what
intended and failed the x86_64 build of Chrome with NDK r10c.
The workaround logic in this CL is identical to r1433, but the #define
magic is applied in a more appropriate proper place this time. Turns
out Breakpad already has an Android compatibility layer, which is
common/android/include. Piggybacking the fix there.

BUG=breakpad:642
R=fdegans@chromium.org, rmcilroy@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1434

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/dump_writer_common/thread_info.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/common/android/include/sys/user.h View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6
primiano
Apologies for the double round. This should be the right way to fix this. I ...
6 years, 2 months ago #1
fdegans
Just a few nits. Other than that, lgtm. https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h File src/common/android/include/sys/user.h (right): https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h#newcode40 src/common/android/include/sys/user.h:40: // ...
6 years, 2 months ago #2
rmcilroy
lgtm. https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h File src/common/android/include/sys/user.h (right): https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h#newcode147 src/common/android/include/sys/user.h:147: #endif // __mips__ On 2015/03/16 12:54:39, fdegans wrote: ...
6 years, 2 months ago #3
fdegans
https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h File src/common/android/include/sys/user.h (right): https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h#newcode147 src/common/android/include/sys/user.h:147: #endif // __mips__ On 2015/03/16 13:31:26, rmcilroy wrote: > ...
6 years, 2 months ago #4
primiano
Thanks https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h File src/common/android/include/sys/user.h (right): https://breakpad.appspot.com/3794002/diff/1/src/common/android/include/sys/user.h#newcode40 src/common/android/include/sys/user.h:40: // - Other platforms: Just use the Android ...
6 years, 2 months ago #5
primiano
6 years, 2 months ago #6
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as 1434 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted