Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 7794002: Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Will Harris
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions.

BUG=chromium:452613
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1427

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/windows/handler/exception_handler.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/client/windows/handler/exception_handler.h View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Will Harris
PTAL - see the chromium bug and https://codereview.chromium.org/919893002/ for more background.
6 years, 3 months ago #1
Mark Mentovai
LGTM
6 years, 3 months ago #2
Will Harris
thanks - will commit this once I get LGTM on the other half.
6 years, 2 months ago #3
Will Harris
Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. BUG=chromium:452613
6 years, 2 months ago #4
Will Harris
6 years, 2 months ago #5
Message was sent while issue was closed.
Committed patchset #3 (id:70001) manually as r1427 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted