Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
1804002	Workaround Android sigaction bug	cjhopman	Mark Mentovai, primiano, tpurtell, torne	3	6 years, 1 month
10724003	Fix call to rt_sigaction	cjhopman	Mark Mentovai		6 years, 2 months
10724002	Use __NR_rt_sigaction instead of __NR_sigaction	cjhopman	Mark Mentovai		6 years, 2 months
7794002	Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. (Closed)	Will Harris	Mark Mentovai		6 years, 3 months
3754003	Fix overflow error in breakpad for linux	kjoswiak	Mark Mentovai, markus	1	6 years, 4 months
1204002	Trim unintentional whitespace and fix style nits (Closed)	mdempsky	Lei Zhang (chromium), vapier		6 years, 4 months
9714003	Fix breakpad on mips and x86_64 for the NDK r10c update.	fdegans	primiano, Mark Mentovai, anton, anton1, pasko, casinobong88	12	6 years, 4 months
2774002	Add memory map permissions to Linux mapping information	arjanl	rmcilroy, Lei Zhang (chromium), casinobong88		6 years, 4 months
10694002	Remove unecessary headers following NDK r10c update. (Closed)	fdegans	rmcilroy, primiano		6 years, 8 months
5724002	Fix clang compilation error introduced in r1380. (Closed)	simonb	rmcilroy		6 years, 8 months
7714003	Extend mapping merge to include reserved but unused mappings. (Closed)	simonb	Lei Zhang (chromium), rmcilroy, Ted Mielczarek		6 years, 8 months
5694002	Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.	joleksy	Mark Mentovai		6 years, 9 months
2744002	Annotate PageAllocator for MSan.	earthdok	Mark Mentovai		6 years, 11 months
7684002	Add support for shared libraries in archives. (Closed)	anton	Lei Zhang (chromium), rmcilroy	31	6 years, 11 months
1694002	[Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation. (Closed)	rmcilroy	Mark Mentovai, Ted Mielczarek		6 years, 11 months
2724002	[NOT FOR REVIEW] Prototype to generate microdumps in logcat.	primiano			6 years, 11 months
7674002	Fix compilation error in Linux libc++ builds due to use of tr1/.	earthdok	Mark Mentovai	4	6 years, 11 months
8664002	Make crash_handler volatile to prevent compiler optimizing it away. (Closed)	anton	Lei Zhang (chromium), rmcilroy		6 years, 11 months
3674002	Fix minor typo in a comment in r1331. (Closed)	rmcilroy	qsr, qsr1		7 years, 1 month
2694002	Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in newer NDKs (Closed)	rmcilroy	Mark Mentovai, qsr1	2	7 years, 1 month

Newer ›