Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 8664002: Make crash_handler volatile to prevent compiler optimizing it away. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by anton
Modified:
7 years ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Make crash_handler volatile to prevent compiler optimizing it away.

This bug manifests itself on Android x64 (in
ExceptionHandlerTest::ExternalDumper), but is possible on any platform. 

The compiler is unaware of the code which runs in the signal handler which reads
this variable. Without volatile the compiler is free to optimise away writes to
this variable which it believes are never read.

BUG=381142, 346626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/handler/exception_handler.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
anton
7 years ago #1
Lei Zhang (chromium)
lgtm
7 years ago #2
rmcilroy
On 2014/07/01 19:51:42, Lei Zhang (chromium) wrote: > lgtm Landing for Anton.
7 years ago #3
rmcilroy
7 years ago #4
On 2014/07/02 10:27:30, rmcilroy wrote:
> On 2014/07/01 19:51:42, Lei Zhang (chromium) wrote:
> > lgtm
> 
> Landing for Anton.

Landed as r1343
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted