Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 1694002: [Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by rmcilroy
Modified:
7 years ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

[Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

__system_property_get has been removed from the Android NDK for 'L' so Breakpad
no longer links. This CL just removes the call in WriteOSInformation because
Chrome already passes the build fingerprint as a crash key called
"android_build_fp" in the crash report HTTP POST message.

BUG=394841,393903
R=mark@chromium.org

Committed: 1351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/minidump_writer/minidump_writer.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 8
rmcilroy
Mark, could you please review this? It is required in order to fix the arm64/x86_64 ...
7 years ago #1
Mark Mentovai
Your CL description says > we already pass the build fingerprint in the "android_build_fp" minidump ...
7 years ago #2
rmcilroy
On 2014/07/18 12:45:36, Mark Mentovai wrote: > Your CL description says > > > we ...
7 years ago #3
Mark Mentovai
That sounds OK, but the description is confusing because you’re talking about what Chrome calls ...
7 years ago #4
rmcilroy
On 2014/07/18 13:06:54, Mark Mentovai wrote: > That sounds OK, but the description is confusing ...
7 years ago #5
rmcilroy
Committed patchset #1 manually as r1351 (presubmit successful).
7 years ago #6
Ted Mielczarek
This kind of sucks because it makes other consumers lose this information. Is there no ...
7 years ago #7
rmcilroy
7 years ago #8
Message was sent while issue was closed.
On 2014/07/18 16:08:37, Ted Mielczarek wrote:
> This kind of sucks because it makes other consumers lose this information. Is
> there no way to get it from C++ at all now?

Unfortunately not, the system_properties_get function was never intended to be a
public API in Android, and the Android team are removing it from 'L'. The best
solution is probably to use Build.FINGERPRINT
(http://developer.android.com/reference/android/os/Build.html#FINGERPRINT) in
Java ahead of time and pass it down via JNI when initializing breakpad (this is
what Chrome does)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted