Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 5724002: Fix clang compilation error introduced in r1380. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by simonb
Modified:
6 years, 10 months ago
Reviewers:
rmcilroy
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Fix clang compilation error introduced in r1380.

Fixes:
  .../linux_dumper.cc:308:25: error: address of array 'module->name' will always
evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                module->name && module->name[0] == '/' &&
                ~~~~~~~~^~~~

BUG=chromium:394703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/minidump_writer/linux_dumper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
simonb
6 years, 10 months ago #1
rmcilroy
On 2014/09/22 14:49:36, simonb wrote: LGTM, thanks.
6 years, 10 months ago #2
rmcilroy
6 years, 10 months ago #3
On 2014/09/22 16:53:37, rmcilroy wrote:
> On 2014/09/22 14:49:36, simonb wrote:
> 
> LGTM, thanks.

Landed as r1384.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted