Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 2694002: Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in newer NDKs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
Reviewers:
Mark Mentovai, qsr1
CC:
qsr, anton
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in
newer NDKs

BUG=346626
TBR=mark@chromium.org

Committed: 1331

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/android/include/sys/user.h View 1 chunk +8 lines, -3 lines 2 comments Download

Messages

Total messages: 4
rmcilroy
TBRing this to fix the x64 Android bot.
7 years, 2 months ago #1
qsr1
LGTM with nit. https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h File common/android/include/sys/user.h (right): https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h#newcode149 common/android/include/sys/user.h:149: // changing lots of Bionic, uUse ...
7 years, 2 months ago #2
rmcilroy
Committed patchset #1 manually as r1331 (presubmit successful).
7 years, 2 months ago #3
rmcilroy
7 years, 2 months ago #4
Message was sent while issue was closed.
https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h
File common/android/include/sys/user.h (right):

https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h...
common/android/include/sys/user.h:149: // changing lots of Bionic, uUse an ugly
macro renaming trick with
On 2014/05/14 09:49:23, qsr1 wrote:
> s/uU/s/

Opps missed this - done in https://breakpad.appspot.com/3674002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted