Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 7674002: Fix compilation error in Linux libc++ builds due to use of tr1/.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by earthdok
Modified:
6 years, 11 months ago
Reviewers:
Mark Mentovai
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

Fix compilation error in Linux libc++ builds due to use of tr1/.
BUG=391792
R=mark@chromium.org

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/dwarf_cu_to_module.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7
earthdok
please take a look
6 years, 11 months ago #1
earthdok
On 2014/07/07 17:58:29, earthdok wrote: > please take a look Oops, patch set 2 coming ...
6 years, 11 months ago #2
earthdok
On 2014/07/07 17:59:26, earthdok wrote: > On 2014/07/07 17:58:29, earthdok wrote: > > please take ...
6 years, 11 months ago #3
Mark Mentovai
The same comments apply where you have the “using” too. https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc File common/dwarf_cu_to_module.cc (right): https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode49 ...
6 years, 11 months ago #4
earthdok
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc File common/dwarf_cu_to_module.cc (right): https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode49 common/dwarf_cu_to_module.cc:49: #if defined(_LIBCPP_VERSION) && defined(__linux__) On 2014/07/07 18:15:28, Mark Mentovai ...
6 years, 11 months ago #5
Mark Mentovai
LGTM
6 years, 11 months ago #6
Mark Mentovai
6 years, 11 months ago #7
Committed Breakpad r1345.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted