Code review - Issue 7674002: Fix compilation error in Linux libc++ builds due to use of tr1/.https://breakpad.appspot.com/2014-07-07T19:23:34+00:00rietveld
Message from unknown
2014-07-07T17:57:51+00:00earthdokurn:md5:606dd03e39d126239fd5d4f111c9e6b3
Message from earthdok@chromium.org
2014-07-07T17:58:29+00:00earthdokurn:md5:4853915e7660b231560f046ecbf54ed8
please take a look
Message from earthdok@chromium.org
2014-07-07T17:59:26+00:00earthdokurn:md5:bd4cad09f48fe21e69410a1af727c2b3
On 2014/07/07 17:58:29, earthdok wrote:
> please take a look
Oops, patch set 2 coming up.
Message from unknown
2014-07-07T18:00:55+00:00earthdokurn:md5:9dc525bce898a35f9d81f11a1cea2ac3
Message from earthdok@chromium.org
2014-07-07T18:01:23+00:00earthdokurn:md5:86ae17d57da44647efc68686b2cb7f4c
On 2014/07/07 17:59:26, earthdok wrote:
> On 2014/07/07 17:58:29, earthdok wrote:
> > please take a look
>
> Oops, patch set 2 coming up.
Updated, sorry about that.
Message from mark@chromium.org
2014-07-07T18:15:27+00:00Mark Mentovaiurn:md5:a903f3baef8d35ec80e47d4265b8af79
The same comments apply where you have the “using” too.
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc
File common/dwarf_cu_to_module.cc (right):
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode49
common/dwarf_cu_to_module.cc:49: #if defined(_LIBCPP_VERSION) && defined(__linux__)
I don’t think __linux__ is necessary. If you’re using libc++ on Mac, it will be <unordered_set> too.
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode50
common/dwarf_cu_to_module.cc:50: // http://crbug.com/391792
I think the #ifdef makes this obvious, you shouldn’t need to include this. Change history will be enough to find it if anyone needs to track it down.
Message from unknown
2014-07-07T18:17:15+00:00earthdokurn:md5:21f7b18a9edf9c91ee061c486b1e20d7
Message from earthdok@chromium.org
2014-07-07T18:18:09+00:00earthdokurn:md5:22f4b98fea1cf26dc7c8570cc768ae84
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc
File common/dwarf_cu_to_module.cc (right):
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode49
common/dwarf_cu_to_module.cc:49: #if defined(_LIBCPP_VERSION) && defined(__linux__)
On 2014/07/07 18:15:28, Mark Mentovai wrote:
> I don’t think __linux__ is necessary. If you’re using libc++ on Mac, it will be
> <unordered_set> too.
Done.
https://breakpad.appspot.com/7674002/diff/40001/common/dwarf_cu_to_module.cc#newcode50
common/dwarf_cu_to_module.cc:50: // http://crbug.com/391792
On 2014/07/07 18:15:28, Mark Mentovai wrote:
> I think the #ifdef makes this obvious, you shouldn’t need to include this.
> Change history will be enough to find it if anyone needs to track it down.
Done.
Message from mark@chromium.org
2014-07-07T19:20:52+00:00Mark Mentovaiurn:md5:89f4a77c75c5b061997ffe3d486240d8
LGTM
Message from mark@chromium.org
2014-07-07T19:23:34+00:00Mark Mentovaiurn:md5:b0eaf8092e810bea16bf4a370972e61e
Committed Breakpad r1345.