Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(351)

Issue 3754003: Fix overflow error in breakpad for linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by kjoswiak
Modified:
2 years, 4 months ago
Reviewers:
Mark Mentovai, markus
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

Fix overflow error in breakpad for linux

A computation in the stack unwind algorithm could cause an overflow if a base
pointer read from crashed process is sufficiently close to top of address space.
This causes a memory read that causes the dump thread to crash, resulting in a
failure to generate crash dump. Check fixed to properly detect that this pointer
is greater than actual memory range of current stack.

BUG=None

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/dump_writer_common/seccomp_unwinder.cc View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 6
kjoswiak
Does this change look reasonable? I ran into this issue on x86 nexus android tv ...
2 years, 4 months ago #1
Mark Mentovai
I’ll take a look a little later, but Markus wrote this, so I’ll give him ...
2 years, 4 months ago #2
markus
LGTM https://breakpad.appspot.com/3754003/diff/1/client/linux/dump_writer_common/seccomp_unwinder.cc File client/linux/dump_writer_common/seccomp_unwinder.cc (right): https://breakpad.appspot.com/3754003/diff/1/client/linux/dump_writer_common/seccomp_unwinder.cc#newcode48 client/linux/dump_writer_common/seccomp_unwinder.cc:48: thread.stack.memory.data_size - sizeof(bp) || Thank you very much ...
2 years, 4 months ago #3
kjoswiak
On 2015/02/05 22:34:35, markus wrote: > LGTM > > https://breakpad.appspot.com/3754003/diff/1/client/linux/dump_writer_common/seccomp_unwinder.cc > File client/linux/dump_writer_common/seccomp_unwinder.cc (right): > ...
2 years, 4 months ago #4
Mark Mentovai
LGTM and I’ll check this in for you. Good catch.
2 years, 4 months ago #5
Mark Mentovai
2 years, 4 months ago #6
Committed r1425.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted