Issue 10724003: Fix call to rt_sigaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 10724003: Fix call to rt_sigaction

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by cjhopman

Modified:
9 years ago

Reviewers:
Mark Mentovai

Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master

Visibility:
Public.

More Reviews

Description

Fix call to rt_sigaction

Despite the fact that many places imply that sigaction and rt_sigaction
are essentially the same, rt_sigaction's signature is actually
different-- it takes the size of the kernel's sigset_t as an extra argument.

This change uses the kernel_sigaction, kernel_sigset_t and sys_rt_sigaction
provided by linux_syscall_support.h instead of rolling our own.

BUG=473973

Patch Set 1 : #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/handler/exception_handler.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM. Good luck.

Expand All Messages | Collapse All Messages