Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 2864002: Microdump processor: be more tolerant for different logcat formats (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by primiano
Modified:
6 years, 1 month ago
Reviewers:
mmandlis
CC:
google-breakpad-dev_googlegroups.com, torne
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Microdump processor: be more tolerant for different logcat formats

The current processor implementation is grepping for /google-breakpad(
in the logcat lines, to filter out microdump lines, which by default
look like this:
W/google-breakpad( 3728): -----BEGIN BREAKPAD MICRODUMP-----

Turns out that logcat format can vary, when passing optional arguments,
and produce something like the following:

04-13 12:30:35.563  6531  6531 W google-breakpad: -----BEGIN ...

In the latter case, the "/google-breakpad(" filter is too aggressive.
This change is relaxing it, so it is compatible also with non-default
logcat arguments.

BUG=640
R=mmandlis@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/microdump.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
primiano
Maria, can you PTAL to this very small change? Note: this is not strictly needed ...
6 years, 1 month ago #1
mmandlis
lgtm
6 years, 1 month ago #2
primiano
6 years, 1 month ago #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1442 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted