Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 3784002: Cleanup Linux debug link file handling code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Lei Zhang (chromium)
Modified:
6 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Cleanup Linux debug link file handling code.

- Handle the case when the debug link points back to the object file.
- Move some checks into a separate SanitizeDebugFile() function.

https://code.google.com/p/google-breakpad/source/detail?r=1426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
src/common/linux/dump_symbols.cc View 5 chunks +74 lines, -44 lines 0 comments Download

Messages

Total messages: 4
Lei Zhang (chromium)
(whoever gets to it first)
6 years, 5 months ago #1
Ted Mielczarek
LGTM
6 years, 5 months ago #2
Mark Mentovai
LGTM
6 years, 5 months ago #3
Lei Zhang (chromium)
6 years, 5 months ago #4
Rietveld feels broken, so I committed directly via SVN as r1426.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted