Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
10734002	add aarch64 support to minidump-2-core	vapier	Ben Chan, Ted Mielczarek		10 years, 1 month
6814002	SH4 support	christian.bruel	Ted Mielczarek, Ben Chan	20	10 years, 1 month
7834002	Support object files larger than 2**32. (Closed)	erikchen	Mark Mentovai	28	10 years, 2 months
6824002	MIPS64: Initial MIPS64 related change. (Closed)	gordanac	rmcilroy, Mark Mentovai	3	10 years, 2 months
3744002	[MIPS]: Use mcontext_t structure for MIPS (Closed)	gordanac	fdegans, Mark Mentovai, primiano, rmcilroy	16	10 years, 2 months
6834002	Merge 1447 "Fix call to rt_sigaction" (Closed)	cjhopman	cjhopman		10 years, 2 months
5784002	Merge 1447 "Fix call to rt_sigaction" (Closed)	cjhopman	cjhopman		10 years, 2 months
1794002	Add address and reason for IN_PAGE_ERROR. (Closed)	bungeman	Mark Mentovai	10	10 years, 2 months
4744002	Support the CrashpadInfo stream. Also: Decode x86 FPU state.	Mark Mentovai			10 years, 3 months
7824002	Fix compilation with gcc --std=c++11	j.turney	Ted Mielczarek, jturney		10 years, 3 months
8684002	Support building src/tools/linux/dump_syms/dump_syms on OS X	jaysoffian	Ted Mielczarek, Mark Mentovai	2	10 years, 3 months
2854003	Write out the actual THUMB function addresses for externs on ARM.	Lei Zhang (chromium)	hashimoto		10 years, 3 months
9774002	Add stack contents output functionality to minidump_stackwalk (Closed)	hashimoto	Mark Mentovai, Ted Mielczarek	2	10 years, 4 months
7804002	WIP (Closed)	hashimoto			10 years, 4 months
9764002	Update license on convert_UTF.* to the standard Unicode license (Closed)	Mark Mentovai	Ted Mielczarek		10 years, 4 months
7784002	Add default debug file search paths to Linux dump_syms.	Lei Zhang (chromium)			10 years, 4 months
3784002	Cleanup Linux debug link file handling code. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		10 years, 4 months
7774002	Handle ARM THUMB functions when removing duplicate PUBLIC entries. (Closed)	Lei Zhang (chromium)	Mark Mentovai, hashimoto, Ted Mielczarek	6	10 years, 4 months
3774002	Add unit tests for overlapping functions and externs. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		10 years, 4 months
2844002	Follow debug link correctly (Closed)	hashimoto	Ted Mielczarek, vapier, Lei Zhang (chromium), Ben Chan, Mark Mentovai	4	10 years, 4 months

Newer ›