Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 3774002: Add unit tests for overlapping functions and externs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Lei Zhang (chromium)
Modified:
6 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add unit tests for overlapping functions and externs.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/module_unittest.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Lei Zhang (chromium)
. o O (We probably should add tests for this) I'll look into adding a ...
6 years, 5 months ago #1
Mark Mentovai
LGTM. Thanks for the test!
6 years, 5 months ago #2
Lei Zhang (chromium)
Committed patchset #1 (id:1) manually as r1424 (presubmit successful).
6 years, 5 months ago #3
Ted Mielczarek
6 years, 5 months ago #4
Message was sent while issue was closed.
On 2015/02/03 23:46:16, Lei Zhang (chromium) wrote:
> . o O (We probably should add tests for this)
> 
> I'll look into adding a bigger test for testing the .gnu_debuglink
> functionality.

Thanks for writing this! Touching that code was painful. I would like to have
some more tests in dump_symbols_unittest.cc, but they're a pain to write because
you need to generate plausible ELF and DWARF test data. That file already has a
synthetic ELF generator based on the TestAssembler code (and tests that generate
symbol tables), and dwarf2reader_die_unittest.cc has some code for generating
synthetic DWARF, so it might not be too bad to leverage all that into generating
a full test of the dump_symbols code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted