Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 6824002: MIPS64: Initial MIPS64 related change. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by gordanac
Modified:
6 years ago
Reviewers:
rmcilroy, Mark Mentovai
CC:
Petar Jovanovic, paul.lind_imgtec.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

MIPS64: Initial MIPS64 related change.

With this change Breakpad can be compiled for MIPS64,
but it is not yet functional.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removing tab. #

Patch Set 3 : Replace ANDROID by __ANDROID__ #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/dump_writer_common/thread_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M client/linux/dump_writer_common/ucontext_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M client/linux/handler/exception_handler_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M client/linux/minidump_writer/linux_dumper.h View 1 chunk +4 lines, -2 lines 0 comments Download
M client/linux/minidump_writer/minidump_writer.cc View 1 chunk +9 lines, -1 line 0 comments Download
M common/android/breakpad_getcontext.S View 1 4 chunks +108 lines, -11 lines 0 comments Download
M common/android/include/link.h View 1 chunk +2 lines, -1 line 0 comments Download
M common/android/testing/include/wchar.h View 2 chunks +4 lines, -0 lines 0 comments Download
M common/android/ucontext_constants.h View 1 chunk +8 lines, -0 lines 0 comments Download
M common/linux/memory_mapped_file.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M common/memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/curl/curl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/curl/curlbuild.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/linux/md2core/minidump-2-core.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rmcilroy
+Mark - I think Mark (or one of the other Breakpad OWNERS) should be reviewing ...
6 years, 1 month ago #1
Mark Mentovai
LGTM https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S File common/android/breakpad_getcontext.S (right): https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S#newcode260 common/android/breakpad_getcontext.S:260: LOCALS_NUM = 1 // save gp on stack ...
6 years, 1 month ago #2
gordanac
Hi Mark, please see comments: https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S File common/android/breakpad_getcontext.S (right): https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontex...<https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S#newcode260> common/android/breakpad_getcontext.S:260: LOCALS_NUM = 1 // ...
6 years, 1 month ago #3
Mark Mentovai
https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h File third_party/curl/curl.h (right): https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77 third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__) I prefer __ANDROID__ too and if ...
6 years, 1 month ago #4
gordanac
Uploaded new patchset: https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77 third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__) On 2015/04/09 20:59:36, Mark Mentovai wrote: > ...
6 years, 1 month ago #5
Mark Mentovai
LGTM
6 years, 1 month ago #6
gordanac
Could you merge that for me? Gordana ________________________________________ From: mark@chromium.org [mark@chromium.org] Sent: Thursday, April 09, ...
6 years, 1 month ago #7
gordanac
Just a friendly reminder for merging this change. ________________________________________ From: Gordana Cmiljanovic Sent: Thursday, April ...
6 years, 1 month ago #8
Mark Mentovai
6 years, 1 month ago #9
Committed r1446.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted