Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(705)

Issue 8684002: Support building src/tools/linux/dump_syms/dump_syms on OS X

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by jaysoffian
Modified:
2 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This allows dumping ELF binaries on OS X, which is useful for folks who build
Android NDK code under OS X.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : updated memrchr.cc from AOSP #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 3 4 4 chunks +37 lines, -21 lines 0 comments Download
M Makefile.in View 1 2 3 4 19 chunks +415 lines, -88 lines 0 comments Download
M configure View 3 chunks +22 lines, -0 lines 0 comments Download
M configure.ac View 1 chunk +9 lines, -0 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/linux/elf_symbols_to_module.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/linux/memory_mapped_file.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/common/linux/safe_readlink.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
A src/common/memrchr.cc View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A src/common/memrchr.h View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M src/common/stabs_reader.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A src/third_party/linux/include/bits/elfclass.h View 1 chunk +14 lines, -0 lines 0 comments Download
A src/third_party/linux/include/bits/link.h View 1 chunk +129 lines, -0 lines 2 comments Download
A src/third_party/linux/include/bits/wordsize.h View 1 chunk +8 lines, -0 lines 0 comments Download
A src/third_party/linux/include/elf.h View 1 chunk +2799 lines, -0 lines 0 comments Download
A src/third_party/linux/include/features.h View 1 chunk +388 lines, -0 lines 0 comments Download
A src/third_party/linux/include/gnu/stubs-64.h View 1 chunk +23 lines, -0 lines 0 comments Download
A src/third_party/linux/include/gnu/stubs.h View 1 chunk +12 lines, -0 lines 0 comments Download
A src/third_party/linux/include/link.h View 1 chunk +194 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jaysoffian
I've tested this by running the ported dump_syms against a few SO's on Linux and ...
2 years, 8 months ago #1
jaysoffian
BTW, I have an individual CLA with Google, but this contribution is in my capacity ...
2 years, 8 months ago #2
jaysoffian
Okay, done futzing with it now till I receive feedback. :-)
2 years, 8 months ago #3
jaysoffian
2 years, 5 months ago #4
Ted Mielczarek
https://breakpad.appspot.com/8684002/diff/180001/src/third_party/linux/include/bits/link.h File src/third_party/linux/include/bits/link.h (right): https://breakpad.appspot.com/8684002/diff/180001/src/third_party/linux/include/bits/link.h#newcode7 src/third_party/linux/include/bits/link.h:7: version 2.1 of the License, or (at your option) ...
2 years, 5 months ago #5
jaysoffian
2 years, 5 months ago #6
https://breakpad.appspot.com/8684002/diff/180001/src/third_party/linux/includ...
File src/third_party/linux/include/bits/link.h (right):

https://breakpad.appspot.com/8684002/diff/180001/src/third_party/linux/includ...
src/third_party/linux/include/bits/link.h:7: version 2.1 of the License, or (at
your option) any later version.
On 2015/03/03 13:15:02, Ted Mielczarek wrote:
> This is going to be a deal-breaker. We can't import LGPL source into the
> Breakpad tree, it's BSD licensed.

Eeek. I'll look into using http://sourceforge.net/p/elftoolchain/wiki/Home/
instead. Other suggestions appreciated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted