Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(372)

Issue 7824002: Fix compilation with gcc --std=c++11

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by j.turney
Modified:
2 years, 3 months ago
Reviewers:
Ted Mielczarek, jturney
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix compilation with gcc --std=c++11

* Replace all uses of typeof with __typeof__ (as is already used in some
places)
* Remove some redundant uses of _cdecl (it appear this could instead be changed
to  __cdecl, but cdecl calling convention is the default anyway)

See https://code.google.com/p/google-breakpad/issues/detail?id=481

Patch Set 1 #

Patch Set 2 : Fix compilation with gcc --std=c++11 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/dump_writer_common/seccomp_unwinder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/client/linux/dump_writer_common/thread_info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/handler/exception_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/minidump_writer/linux_dumper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/tests/crash_generation_app/crash_generation_app.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/common/linux/eintr_wrapper.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Ted Mielczarek
LGTM. Not sure why we didn't do this sooner.
2 years, 3 months ago #1
Ted Mielczarek
Landed: https://code.google.com/p/google-breakpad/source/detail?r=1435
2 years, 3 months ago #2
jturney
On 2015/03/24 11:25:59, Ted Mielczarek wrote: > Landed: > https://code.google.com/p/google-breakpad/source/detail?r=1435 Thanks. Note that it looks ...
2 years, 3 months ago #3
Ted Mielczarek
2 years, 3 months ago #4
On 2015/03/24 12:07:16, jturney wrote:
> Note that it looks like building 'make check' with --std=c++11 needs a later
> version of gtest than the one currently included in breakpad.

If you can verify that updating to a newer gtest doesn't break anything in the
Breakpad build I'd be happy to do that for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted