Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 7834002: Support object files larger than 2**32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by erikchen
Modified:
3 years, 3 months ago
Reviewers:
Mark Mentovai
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Support object files larger than 2**32.

This CL adds a new class SuperFatArch, which is very similar to struct fat_arch,
but allows for object files larger than 2**32.

Patch Set 1 #

Patch Set 2 : #

Total comments: 18

Patch Set 3 : Comments from mark. #

Total comments: 8

Patch Set 4 : Comments from mark, round two. #

Total comments: 2

Patch Set 5 : Comments from mark, round three. #

Patch Set 6 : Uploading from a different checkout. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/common.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M common/mac/dump_syms.h View 1 2 3 4 5 5 chunks +15 lines, -8 lines 0 comments Download
M common/mac/dump_syms.mm View 1 2 3 4 5 5 chunks +55 lines, -5 lines 0 comments Download
M common/mac/macho_reader.cc View 1 2 3 4 5 6 chunks +17 lines, -15 lines 0 comments Download
M common/mac/macho_reader.h View 1 2 3 4 5 8 chunks +11 lines, -10 lines 0 comments Download
A common/mac/super_fat_arch.h View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
M tools/mac/dump_syms/dump_syms_tool.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10
erikchen
mark: Please review.
3 years, 3 months ago #1
Mark Mentovai
https://breakpad.appspot.com/7834002/diff/20001/src/common/mac/dump_syms.mm File src/common/mac/dump_syms.mm (right): https://breakpad.appspot.com/7834002/diff/20001/src/common/mac/dump_syms.mm#newcode210 src/common/mac/dump_syms.mm:210: SuperFatArch *DumpSymbols::FindBestMatchForArchitecture(cpu_type_t cpu_type, cpu_subtype_t cpu_subtype) { * on the ...
3 years, 3 months ago #2
erikchen
mark: PTAL https://breakpad.appspot.com/7834002/diff/20001/src/common/mac/dump_syms.mm File src/common/mac/dump_syms.mm (right): https://breakpad.appspot.com/7834002/diff/20001/src/common/mac/dump_syms.mm#newcode210 src/common/mac/dump_syms.mm:210: SuperFatArch *DumpSymbols::FindBestMatchForArchitecture(cpu_type_t cpu_type, cpu_subtype_t cpu_subtype) { On ...
3 years, 3 months ago #3
Mark Mentovai
LGTM https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h File common/mac/dump_syms.h (right): https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h#newcode180 common/mac/dump_syms.h:180: vector<SuperFatArch> object_files_; Add an explicit () initializer to ...
3 years, 3 months ago #4
erikchen
https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h File common/mac/dump_syms.h (right): https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h#newcode180 common/mac/dump_syms.h:180: vector<SuperFatArch> object_files_; On 2015/04/22 04:17:54, Mark Mentovai wrote: > ...
3 years, 3 months ago #5
Mark Mentovai
https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h File common/mac/dump_syms.h (right): https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h#newcode180 common/mac/dump_syms.h:180: vector<SuperFatArch> object_files_; On 2015/04/22 18:11:27, erikchen wrote: > On ...
3 years, 3 months ago #6
erikchen
https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h File common/mac/dump_syms.h (right): https://breakpad.appspot.com/7834002/diff/90015/common/mac/dump_syms.h#newcode180 common/mac/dump_syms.h:180: vector<SuperFatArch> object_files_; On 2015/04/22 18:21:30, Mark Mentovai wrote: > ...
3 years, 3 months ago #7
Mark Mentovai
LGTM https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm File common/mac/dump_syms.mm (right): https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm#newcode43 common/mac/dump_syms.mm:43: #include <assert.h> Move this above to the C ...
3 years, 3 months ago #8
erikchen
https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm File common/mac/dump_syms.mm (right): https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm#newcode43 common/mac/dump_syms.mm:43: #include <assert.h> Done
3 years, 3 months ago #9
erikchen
3 years, 3 months ago #10
On 2015/04/22 18:31:47, erikchen wrote:
> https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm
> File common/mac/dump_syms.mm (right):
> 
>
https://breakpad.appspot.com/7834002/diff/270001/common/mac/dump_syms.mm#newc...
> common/mac/dump_syms.mm:43: #include <assert.h>
> Done

Manually committed as r1453.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted