Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 1794002: Add address and reason for IN_PAGE_ERROR. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by bungeman
Modified:
6 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add address and reason for IN_PAGE_ERROR.

ACCESS_VIOLATION and IN_PAGE_ERROR both specify
read/write/dep flags and address. ACCESS_VIOLATION currently
reports these, but IN_PAGE_ERROR does not. This change makes
IN_PAGE_ERROR report this information as well, and also the
additional NTSTATUS value for the underlying cause.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix some formatting. #

Total comments: 6

Patch Set 3 : Cleaner generation of values. #

Patch Set 4 : Split out symbolic constants. #

Total comments: 2

Patch Set 5 : Fix formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 3 4 4 chunks +5 lines, -0 lines 0 comments Download
M Makefile.in View 1 2 3 4 11 chunks +17 lines, -2 lines 0 comments Download
M src/google_breakpad/common/minidump_exception_win32.h View 1 2 3 4 2 chunks +2145 lines, -0 lines 0 comments Download
M src/processor/minidump_processor.cc View 1 2 3 3 chunks +45 lines, -3 lines 0 comments Download
M src/processor/processor.gyp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A src/processor/symbolic_constants_win.cc View 1 2 3 4 1 chunk +6417 lines, -0 lines 0 comments Download
A src/processor/symbolic_constants_win.h View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 10
bungeman
https://breakpad.appspot.com/1794002/diff/1/src/google_breakpad/common/minidump_exception_win32.h File src/google_breakpad/common/minidump_exception_win32.h (right): https://breakpad.appspot.com/1794002/diff/1/src/google_breakpad/common/minidump_exception_win32.h#newcode1898 src/google_breakpad/common/minidump_exception_win32.h:1898: MD_NTSTATUS_WIN_STATUS_VHD_DIFFERENCING_CHAIN_ERROR_IN_PARENT = 0xC03A0019, Need to remove trailing comma for ...
6 years, 1 month ago #1
bungeman
There is a certain class of crashes Windows I'm currently investigating but a great many ...
6 years, 1 month ago #2
Mark Mentovai
https://breakpad.appspot.com/1794002/diff/40001/src/google_breakpad/common/minidump_exception_win32.h File src/google_breakpad/common/minidump_exception_win32.h (right): https://breakpad.appspot.com/1794002/diff/40001/src/google_breakpad/common/minidump_exception_win32.h#newcode115 src/google_breakpad/common/minidump_exception_win32.h:115: MD_NTSTATUS_WIN_STATUS_USER_APC = 0x000000C0, I hope you did this whole ...
6 years, 1 month ago #3
bungeman
Note that I'm really doing this to scratch an itch; I'm not really all that ...
6 years, 1 month ago #4
Mark Mentovai
I meant to break GetNTSTATUSReason() into its own file. Looks like I put the comment ...
6 years, 1 month ago #5
Mark Mentovai
Apologies for the duplicate, but breakpad.appsopt.com doesn’t show the comment (yet?) so I’m trying one ...
6 years, 1 month ago #6
bungeman
symbolic_constants_win it is. I've split this out and managed to figure out how add the ...
6 years, 1 month ago #7
Mark Mentovai
LGTM otherwise. https://breakpad.appspot.com/1794002/diff/170001/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1794002/diff/170001/Makefile.am#newcode269 Makefile.am:269: src/processor/symbolic_constants_win.cc\ Space before \, here and on ...
6 years, 1 month ago #8
bungeman
I'm not currently a committer on the project, so feel free to land this yourself, ...
6 years, 1 month ago #9
Mark Mentovai
6 years, 1 month ago #10
Cool, I landed this as r1441. If you have more patches, I’ll make you a
committer. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted