Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 10734002: add aarch64 support to minidump-2-core

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by vapier
Modified:
1 year, 10 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

add aarch64 support to minidump-2-core

The thread info expects the struct names as they expect in asm/ptrace.h,
but the header doesn't include that, it includes sys/user.h.  Rename the
reg structs to match that header.

Rename the elf_siginfo to _elf_siginfo to avoid conflicting with the one
in the sys/procfs.h.  It is only used locally in one place, so we don't
need to update any callers.

Otherwise, drop in aarch64 support into the minidump-2-core file.

BUG=chromium:334368

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/dump_writer_common/thread_info.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 5 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 4
vapier
1 year, 11 months ago #1
Ben Chan
+1 On Fri, Apr 17, 2015 at 10:07 PM, <vapier@chromium.org> wrote: > Reviewers: Ben Chan, ...
1 year, 11 months ago #2
Ted Mielczarek
One of these days someone is going to break down and fix minidump2core to work ...
1 year, 10 months ago #3
vapier
1 year, 10 months ago #4
i don't have any more plans for big work on breakpad what with crashpad coming
down the pike
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted