Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 10714002: Microdump writer: stop using new/malloc in compromised context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by primiano
Modified:
6 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com, Mark Mentovai, mmandlis
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Microdump writer: stop using new/malloc in compromised context

A recent change in the client-side microdump write (r1404) ended up
introducing a call to new() to instantiate the line buffer that
microdump uses to dump its lines. new/malloc is a luxury we cannot
afford in a compromised context.
This change switches the line buffer to be backed by the dumper
page allocator, which on Linux/Android ends up requesting pages
via mmap.
Also, the microdump write bails out without crashing if the page
allocator failed (crash during severe OOM).

BUG=640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/microdump_writer/microdump_writer.cc View 6 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 3
primiano
Lei, would you mind taking a look to this very small fix? Thanks.
6 years, 4 months ago #1
Lei Zhang (chromium)
lgtm
6 years, 4 months ago #2
primiano
6 years, 4 months ago #3
Message was sent while issue was closed.
On 2015/03/10 18:46:35, Lei Zhang (chromium) wrote:
> lgtm

Landed in r1432.
(Sigh, I keep using svn dcommit rather than cl dcommit by mistake)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted