Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 7814002: Make breakpad compatible with Android NDK r10d. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by primiano
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy, fdegans
CC:
google-breakpad-dev_googlegroups.com, Lei Zhang (chromium)
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make breakpad compatible with Android NDK r10d.

r1397 did introduce a workaround to deal with a typo in sys/user.h
in the Android NDK. The typo has been fixed in [1]. However, breakpad
cannot just switch to the fixed version as this would require atomic
rolls of Breakpad and NDK in chromium, which would make reverts hard
to handle.
This change introduces an inelegant yet functional hack which makes
breakpad compatible with both versions of the NDK, with and without
the typo. It can be reverted once Chrome has stably rolled to NDK
r10d.

[1] https://android.googlesource.com/platform/bionic/+/f485547b

BUG=breakpad:642
R=fdegans@chromium.org, rmcilroy@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/dump_writer_common/thread_info.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/client/linux/dump_writer_common/thread_info.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
primiano
6 years, 2 months ago #1
fdegans
lgtm That will prevent us from having to do a 3-way roll again.
6 years, 2 months ago #2
rmcilroy
On 2015/03/10 16:38:46, fdegans wrote: > lgtm > That will prevent us from having to ...
6 years, 2 months ago #3
primiano
6 years, 2 months ago #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1433 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted