Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 1784002: Fix the scope on the initialization of kMicrodumpOnConsole to match header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by primiano
Modified:
6 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com, azarchs_chromium.org
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix the scope on the initialization of kMicrodumpOnConsole to match header.

I whish I knew how this worked for months in chromium as it is clearly wrong.
As reported by azarchs@ it is breaking the cygprofile instrumented build.


BUG=chromium:410294
TBR=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1413

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/handler/minidump_descriptor.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9
primiano
Thanks +azarchs@
6 years, 6 months ago #1
primiano
Committed patchset #2 (id:20001) manually as 1413 (presubmit successful).
6 years, 6 months ago #2
primiano
TBR'ing mark as this is a trivial fix and is breaking a build.
6 years, 6 months ago #3
Mark Mentovai
LGTM
6 years, 6 months ago #4
casinobong88
https://mb.b88ag.com/(S(yx05tb3x40dwmm2pin23zwd2))/index.aspx
6 years, 6 months ago #5
casinobong88
On 2015/01/20 23:30:19, casinobong88 wrote: > https://mb.b88ag.com/%28S%28yx05tb3x40dwmm2pin23zwd2%29%29/index.aspx ttps://mb.b88ag.com/%28S%28yy3b2annsq2ya3t5ekumptdk%29%29/_MemberInfo/CustomerList/Master/AgentList.aspx
6 years, 6 months ago #6
toi481982
On 2015/01/21 00:13:33, casinobong88 wrote: > On 2015/01/20 23:30:19, casinobong88 wrote: > > https://mb.b88ag.com/%2528S%2528yx05tb3x40dwmm2pin23zwd2%2529%2529/index.aspx > ...
6 years, 6 months ago #7
toi481982
On 2015/01/21 00:44:05, toi481982 wrote: > On 2015/01/21 00:13:33, casinobong88 wrote: > > On 2015/01/20 ...
6 years, 6 months ago #8
toi481982
6 years, 2 months ago #9
Message was sent while issue was closed.
76940438
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted