Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 9784002: Fix Windows dump_syms x64 linking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Ted Mielczarek
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The dia_sdk GYP target currently points at the x86 diaguids.lib, it needs to
point at the x64 one for x64 builds. I verified that both x86 and x64 builds
from Visual C++ work for me with this patch.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Swap slashes #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/windows/common_windows.gyp View 1 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
6 years, 2 months ago #1
Ted Mielczarek
Not sure if this sent mail when I added the reviewer.
6 years, 2 months ago #2
Mark Mentovai
https://breakpad.appspot.com/9784002/diff/1/src/common/windows/common_windows.gyp File src/common/windows/common_windows.gyp (right): https://breakpad.appspot.com/9784002/diff/1/src/common/windows/common_windows.gyp#newcode40 src/common/windows/common_windows.gyp:40: r'$(VSInstallDir)\DIA SDK\include', Don’t use r-strings, these aren’t supposed to ...
6 years, 2 months ago #3
Ted Mielczarek
I never remember --send-mail.
6 years, 2 months ago #4
Mark Mentovai
6 years, 2 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted