Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
7744002	Enable SIGABRT handler for out-of-process handlers on OS X as well	Ted Mielczarek	Mark Mentovai		10 years, 8 months
9784002	Fix Windows dump_syms x64 linking (Closed)	Ted Mielczarek	Mark Mentovai	1	10 years, 10 months
530002	Stop using dynamic_cast in dwarf2reader (Closed)	Ted Mielczarek	jimb		11 years, 2 months
519002	Rework PostfixEvaluator to use a UniqueString type (Closed)	Ted Mielczarek	jimb		11 years, 2 months
520002	Replace map<UniqueString*> with UniqueStringMap (Closed)	Ted Mielczarek	jimb		11 years, 2 months
511003	Add APIs for querying Module data (Closed)	Ted Mielczarek	jimb, Mark Mentovai, Lei Zhang (chromium), glandium	2	11 years, 2 months
516004	Change representation of CFI rules (Closed)	Ted Mielczarek	Mark Mentovai, jimb		11 years, 2 months
3704002	Stringify minidump stream_type constants in minidump_dump output (Closed)	Ted Mielczarek	Mark Mentovai	1	11 years, 6 months
7654002	Print more x86-64 registers in minidump_stackwalk (Closed)	Ted Mielczarek	Mark Mentovai		11 years, 7 months
618002	Enable SIGABRT handler on desktop OS X (Closed)	Ted Mielczarek	Mark Mentovai	3	12 years, 4 months
480002	Parse ARM unwind tables	Ted Mielczarek	jimb, vasily.golubev		12 years, 8 months
539003	Fix Windows unittest build on VC2012 (Closed)	Ted Mielczarek	Mark Mentovai		12 years, 9 months
425002	Linux MinidumpWriter should properly set number_of_processors on ARM (Closed)	Ted Mielczarek	digit		12 years, 10 months
522002	Add ReadSymbolData method to Mac dumper code (Closed)	Ted Mielczarek	Mark Mentovai		12 years, 10 months
538002	Make OOP mac crashreporting exit after writing dump (Closed)	Ted Mielczarek	Mark Mentovai	2	12 years, 10 months
517002	Allow dumping just CFI data from debug symbols (Closed)	Ted Mielczarek	Lei Zhang (chromium)	9	12 years, 10 months
536002	Allow building symbol dumping without STABS support (Closed)	Ted Mielczarek	Lei Zhang (chromium), Mark Mentovai		12 years, 10 months
535003	Fix some more processor code to build on Win32 (Closed)	Ted Mielczarek	Mark Mentovai		12 years, 10 months
521002	Minor Android fixup in symbol dumping code (Closed)	Ted Mielczarek	digit	1	12 years, 10 months
535002	Use stdint types everywhere. (Closed)	Ted Mielczarek	Mark Mentovai, ted	15	12 years, 10 months

Newer ›