Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
7744002	Enable SIGABRT handler for out-of-process handlers on OS X as well	Ted Mielczarek	Mark Mentovai		5 years, 4 months
9784002	Fix Windows dump_syms x64 linking (Closed)	Ted Mielczarek	Mark Mentovai	1	5 years, 6 months
530002	Stop using dynamic_cast in dwarf2reader (Closed)	Ted Mielczarek	jimb		5 years, 10 months
519002	Rework PostfixEvaluator to use a UniqueString type (Closed)	Ted Mielczarek	jimb		5 years, 10 months
520002	Replace map<UniqueString*> with UniqueStringMap (Closed)	Ted Mielczarek	jimb		5 years, 10 months
511003	Add APIs for querying Module data (Closed)	Ted Mielczarek	jimb, Mark Mentovai, Lei Zhang (chromium), glandium	2	5 years, 10 months
516004	Change representation of CFI rules (Closed)	Ted Mielczarek	Mark Mentovai, jimb		5 years, 10 months
3704002	Stringify minidump stream_type constants in minidump_dump output (Closed)	Ted Mielczarek	Mark Mentovai	1	6 years, 2 months
7654002	Print more x86-64 registers in minidump_stackwalk (Closed)	Ted Mielczarek	Mark Mentovai		6 years, 4 months
618002	Enable SIGABRT handler on desktop OS X (Closed)	Ted Mielczarek	Mark Mentovai	3	7 years, 1 month
480002	Parse ARM unwind tables	Ted Mielczarek	jimb, vasily.golubev		7 years, 5 months
539003	Fix Windows unittest build on VC2012 (Closed)	Ted Mielczarek	Mark Mentovai		7 years, 6 months
425002	Linux MinidumpWriter should properly set number_of_processors on ARM (Closed)	Ted Mielczarek	digit		7 years, 6 months
522002	Add ReadSymbolData method to Mac dumper code (Closed)	Ted Mielczarek	Mark Mentovai		7 years, 6 months
538002	Make OOP mac crashreporting exit after writing dump (Closed)	Ted Mielczarek	Mark Mentovai	2	7 years, 6 months
517002	Allow dumping just CFI data from debug symbols (Closed)	Ted Mielczarek	Lei Zhang (chromium)	9	7 years, 6 months
536002	Allow building symbol dumping without STABS support (Closed)	Ted Mielczarek	Lei Zhang (chromium), Mark Mentovai		7 years, 6 months
535003	Fix some more processor code to build on Win32 (Closed)	Ted Mielczarek	Mark Mentovai		7 years, 6 months
521002	Minor Android fixup in symbol dumping code (Closed)	Ted Mielczarek	digit	1	7 years, 6 months
535002	Use stdint types everywhere. (Closed)	Ted Mielczarek	Mark Mentovai, ted	15	7 years, 6 months

Newer ›