Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4481)

Issue 520002: Replace map<UniqueString*> with UniqueStringMap (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Ted Mielczarek
Modified:
9 years, 5 months ago
Reviewers:
jimb
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Further profiling of stack unwinding found that std::map was fairly
allocation-heavy. Julian implemented a UniqueStringMap class, which stores a
small fixed array of UniqueString* and simply does linear search on them, which
turns out to be faster than using std::map for our use cases (most usage of
PostfixEvaluator tends to have a small number of keys). UniqueStringMap
overflows to a std::map internally. Patch is originally by Julian Seward.

Patch Set 1 #

Patch Set 2 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/unique_string.h View 2 chunks +102 lines, -0 lines 0 comments Download
M src/processor/basic_source_line_resolver_unittest.cc View 4 chunks +20 lines, -15 lines 0 comments Download
M src/processor/cfi_frame_info-inl.h View 1 chunk +15 lines, -15 lines 0 comments Download
M src/processor/cfi_frame_info.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/processor/cfi_frame_info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/cfi_frame_info_unittest.cc View 7 chunks +33 lines, -41 lines 0 comments Download
M src/processor/fast_source_line_resolver_unittest.cc View 3 chunks +21 lines, -16 lines 0 comments Download
M src/processor/postfix_evaluator-inl.h View 3 chunks +11 lines, -11 lines 0 comments Download
M src/processor/postfix_evaluator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/processor/postfix_evaluator_unittest.cc View 3 chunks +27 lines, -30 lines 0 comments Download
M src/processor/stackwalker_arm.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M src/processor/stackwalker_x86.cc View 5 chunks +29 lines, -28 lines 0 comments Download

Messages

Total messages: 1
Ted Mielczarek
11 years, 2 months ago #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted