Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 511003: Add APIs for querying Module data (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Ted Mielczarek
Modified:
5 years, 9 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

We have a use case for loading debug symbols and querying the info out of the
Module object directly. This patch adds some methods to Module to query symbol
data by address. As part of this, it changes the StackFrameEntry storage from
vector to set so we can search it more easily.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/module.cc View 4 chunks +63 lines, -6 lines 2 comments Download
M src/common/module.h View 3 chunks +23 lines, -1 line 0 comments Download
M src/common/module_unittest.cc View 2 chunks +169 lines, -22 lines 0 comments Download

Messages

Total messages: 4
Ted Mielczarek
7 years, 7 months ago #1
Ted Mielczarek
More review trolling.
7 years, 6 months ago #2
Ted Mielczarek
Can you take a look at this patch too? Perhaps got lost in the shuffle.
7 years, 6 months ago #3
glandium
7 years, 6 months ago #4
LGTM. Just nits.

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc
File src/common/module.cc (right):

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc#newcode134
src/common/module.cc:134: return NULL;
This would probably read better if it was
  if ((*it)->address <= address && address < (*it)->address + (*it)->size)
    return *it;
  return NULL;

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc#newcode214
src/common/module.cc:214: return NULL;
Likewise. It might be worth templating or something, to avoid code duplication.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted