Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8695)

Issue 538002: Make OOP mac crashreporting exit after writing dump (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Ted Mielczarek
Modified:
11 years ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

I stumbled over this in Mozilla bug 848075, it's causing our tests to hang
occasionally. The OOP minidump writing code path in the Mac ExceptionHandler
doesn't honor exit_after_write, so it calls back into exc_server, which winds up
calling dlsym in libkern to find catch_exception_raise. Unfortunately dlsym can
malloc, which can deadlock because the other threads are suspended. Making the
OOP code path behave similarly to the in-process path fixes this issue.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/exception_handler.cc View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 4
Ted Mielczarek
11 years ago #1
Mark Mentovai
http://breakpad.appspot.com/538002/diff/1/src/client/mac/handler/exception_handler.cc File src/client/mac/handler/exception_handler.cc (right): http://breakpad.appspot.com/538002/diff/1/src/client/mac/handler/exception_handler.cc#newcode372 src/client/mac/handler/exception_handler.cc:372: _exit(exception_type); I don’t think this will prevent Apple’s Crash ...
11 years ago #2
Ted Mielczarek
http://breakpad.appspot.com/538002/diff/1/src/client/mac/handler/exception_handler.cc File src/client/mac/handler/exception_handler.cc (right): http://breakpad.appspot.com/538002/diff/1/src/client/mac/handler/exception_handler.cc#newcode372 src/client/mac/handler/exception_handler.cc:372: _exit(exception_type); On 2013/03/06 19:44:29, Mark Mentovai wrote: > I ...
11 years ago #3
Mark Mentovai
11 years ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted