Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 7744002: Enable SIGABRT handler for out-of-process handlers on OS X as well

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Ted Mielczarek
Modified:
1 year, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Currently the SIGABRT handler on OS X doesn't get enabled for out-of-process
handlers. I can't find any justification for this in the initial implementation
other than it was written solely for iOS where we don't actually support
out-of-process handlers. My coworker wrote this patch and we've had it applied
locally for a while and it seems to work fine for us, it hasn't shipped in a
release yet but it's in our beta channel and we haven't seen any problems. It's
useful since it allows `kill -ABRT` for child processes to produce a minidump.

Mark: I reviewed this in bugzilla but can you give it a once-over?

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/exception_handler.cc View 1 chunk +15 lines, -16 lines 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
2 years, 6 months ago #1
Mark Mentovai
In Chrome, we do this https://chromium.googlesource.com/chromium/src/+/00ea022b81af/components/crash/app/breakpad_mac.mm so I don’t want to take this in the ...
2 years, 6 months ago #2
Ted Mielczarek
On 2014/10/24 12:45:44, Mark Mentovai wrote: > In Chrome, we do this > > https://chromium.googlesource.com/chromium/src/+/00ea022b81af/components/crash/app/breakpad_mac.mm ...
2 years, 6 months ago #3
Ted Mielczarek
On 2014/10/24 15:03:37, Ted Mielczarek wrote: > On 2014/10/24 12:45:44, Mark Mentovai wrote: > > ...
1 year, 11 months ago #4
Mark Mentovai
1 year, 11 months ago #5
LGTM. I didn’t really think the code change through very carefully, but I’m not
using this code anymore, and if it makes things easier for you, that’s a
benefit.

I also encourage you to look at integrating the Crashpad client for Mac too. It
may suit your needs well (and if not, I’d be interested in knowing what about it
is unappealing).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted