Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(778)

Issue 519002: Rework PostfixEvaluator to use a UniqueString type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Ted Mielczarek
Modified:
9 years, 5 months ago
Reviewers:
jimb
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Profiling of stack unwinding found that a large portion of the time was spent
doing string comparisons as a result of using std::map<string,...> in
PostfixEvaluator. This patch introduces a UniqueString type which atomizes
strings so we can simply do pointer comparisons on them, and makes
PostfixEvaluator use it internally.

Patch Set 1 #

Patch Set 2 : Updated Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 9 chunks +10 lines, -0 lines 0 comments Download
M Makefile.in View 26 chunks +50 lines, -4 lines 0 comments Download
M src/common/dwarf_cfi_to_module.cc View 4 chunks +24 lines, -18 lines 0 comments Download
M src/common/dwarf_cfi_to_module.h View 3 chunks +15 lines, -27 lines 0 comments Download
M src/common/dwarf_cfi_to_module_unittest.cc View 1 2 chunks +63 lines, -49 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/common/mac/dump_syms.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/common/module.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/common/module.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/common/module_unittest.cc View 1 6 chunks +53 lines, -35 lines 0 comments Download
A src/common/unique_string.cc View 1 1 chunk +110 lines, -0 lines 0 comments Download
A src/common/unique_string.h View 1 1 chunk +239 lines, -0 lines 0 comments Download
M src/processor/basic_source_line_resolver_unittest.cc View 3 chunks +29 lines, -20 lines 0 comments Download
M src/processor/cfi_frame_info.cc View 1 3 chunks +30 lines, -12 lines 0 comments Download
M src/processor/cfi_frame_info.h View 6 chunks +11 lines, -8 lines 0 comments Download
M src/processor/cfi_frame_info_unittest.cc View 9 chunks +82 lines, -62 lines 0 comments Download
M src/processor/fast_source_line_resolver_unittest.cc View 3 chunks +29 lines, -20 lines 0 comments Download
M src/processor/postfix_evaluator-inl.h View 6 chunks +50 lines, -45 lines 0 comments Download
M src/processor/postfix_evaluator.h View 3 chunks +19 lines, -4 lines 0 comments Download
M src/processor/postfix_evaluator_unittest.cc View 6 chunks +77 lines, -57 lines 0 comments Download
M src/processor/stackwalker_amd64.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M src/processor/stackwalker_arm.cc View 3 chunks +16 lines, -7 lines 0 comments Download
M src/processor/stackwalker_x86.cc View 6 chunks +37 lines, -37 lines 0 comments Download
M src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj View 1 6 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
Neglected to mention, this patch is originally by Julian Seward.
11 years, 2 months ago #1
Ted Mielczarek
11 years, 2 months ago #2

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted