Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 618002: Enable SIGABRT handler on desktop OS X (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Ted Mielczarek
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The iOS port has a SIGABRT handler which turns out to be useful on desktop OS X
for a number of reasons (https://bugzilla.mozilla.org/show_bug.cgi?id=717758,
for example). The code as-written mostly works, it just needed the extra
handling in MinidumpGenerator::GetThreadState to do the right thing. I spent
extra time writing the unit test because without that block of code it still
produced minidumps, but the exception context was all wrong. I still can't
figure out how to write a really rigorous unit test, but I gave up.

Patch Set 1 #

Patch Set 2 : Remove extraneous xcode project hunks #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/exception_handler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/client/mac/handler/minidump_generator.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/client/mac/tests/exception_handler_test.cc View 1 chunk +29 lines, -6 lines 3 comments Download

Messages

Total messages: 5
Ted Mielczarek
7 years, 3 months ago #1
Ted Mielczarek
7 years, 3 months ago #2
Ted Mielczarek
Sorry, I was having build issues on 10.8 and resorted to hacking the XCode projects, ...
7 years, 3 months ago #3
Mark Mentovai
LGTM https://breakpad.appspot.com/618002/diff/3001/src/client/mac/tests/exception_handler_test.cc File src/client/mac/tests/exception_handler_test.cc (right): https://breakpad.appspot.com/618002/diff/3001/src/client/mac/tests/exception_handler_test.cc#newcode140 src/client/mac/tests/exception_handler_test.cc:140: } …otherwise expect that it’s not this pair? ...
7 years, 3 months ago #4
Ted Mielczarek
7 years, 3 months ago #5

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted