Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 6724002: Fix copyright notice in dump_context.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by primiano
Modified:
6 years, 3 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix copyright notice in dump_context.cc

BUG=chromium:410294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/dump_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
vapier
i don't see the issue. Chromium copyright policy is explicit: do not update the Copyright ...
6 years, 3 months ago #1
primiano
On 2015/01/27 13:46:27, vapier wrote: > i don't see the issue. Chromium copyright policy is ...
6 years, 3 months ago #2
primiano
6 years, 3 months ago #3
On 2015/01/27 14:03:35, primiano wrote:
> On 2015/01/27 13:46:27, vapier wrote:
> > i don't see the issue.  Chromium copyright policy is explicit: do not update
> the
> > Copyright header (year) once the file has been created.
> 
> NOT LGTM.
> Agree with vapier@, copyright notice should reflect the creation date of the
> file and should not be touched afterwards.
> Please see: http://www.chromium.org/developers/coding-style
> Similar rules apply internally.

Hold on, did I just "NOT LGTM" a CL from myself? ^__^
facepalm.

I have absolutely no memory of this. 

I will silently close this issue in shame.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted