Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 1114003: Expose ExceptionHandler::HandleSignal for use in non-breakpad signal handlers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Jed Davis
Modified:
6 years, 6 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Make ExceptionHandler::HandleSignal public, for use in non-breakpad signal
handlers — for example, Gecko's seccomp-bpf integration includes a SIGSYS
handler from which it would be useful to create a crash dump with the original
signal context.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/handler/exception_handler.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 1
Ted Mielczarek
7 years, 3 months ago #1
This LGTM.

For reference, the upstream Mozilla bug is
https://bugzilla.mozilla.org/show_bug.cgi?id=945498 .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted