Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 4704002: Introduce microdump_stackwalk comand line executable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by primiano
Modified:
6 years, 5 months ago
Reviewers:
mmandlis, Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Introduce microdump_stackwalk comand line executable

This introduces the microdump_stackwalk binary which takes advantage
of the MicrodumpProcessor to symbolize microdumps.
Its operation is identical to the one of minidump_stackwalk.
This CL, in fact, is also refactoring most of the common bits into
stackwalk_common.

BUG=chromium:410294
R=mmandlis@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1405

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address Maria's review. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 8 chunks +43 lines, -5 lines 0 comments Download
M Makefile.in View 1 2 20 chunks +111 lines, -11 lines 0 comments Download
A src/processor/microdump_stackwalk.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A src/processor/microdump_stackwalk_machine_readable_test View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A src/processor/microdump_stackwalk_test View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M src/processor/minidump_stackwalk.cc View 4 chunks +9 lines, -734 lines 0 comments Download
A src/processor/stackwalk_common.cc View 1 2 1 chunk +767 lines, -0 lines 0 comments Download
A src/processor/stackwalk_common.h View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk.machine_readable.out View 1 chunk +129 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk.out View 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 7
primiano
There we go: all the pieces coming together!
6 years, 5 months ago #1
mmandlis
https://breakpad.appspot.com/4704002/diff/1/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/4704002/diff/1/Makefile.am#newcode1157 Makefile.am:1157: src/processor/stackwalker_address_list.o \ it should be alphabetized, shouldn't it? please, ...
6 years, 5 months ago #2
primiano
https://breakpad.appspot.com/4704002/diff/1/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/4704002/diff/1/Makefile.am#newcode1157 Makefile.am:1157: src/processor/stackwalker_address_list.o \ On 2014/11/24 17:56:00, mmandlis wrote: > it ...
6 years, 5 months ago #3
mmandlis
lgtm PS: sorry, i should've checked the diffs more carefully. On 2014/11/24 18:39:30, primiano wrote: ...
6 years, 5 months ago #4
primiano
+mark: nothing exciting in this CL. Just moving common bits of the minidump_stackwalker.cc into a ...
6 years, 5 months ago #5
Mark Mentovai
Thanks for including me. This seems fine.
6 years, 5 months ago #6
primiano
6 years, 5 months ago #7
Message was sent while issue was closed.
Committed patchset #3 (id:170001) manually as 1405 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted