Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 6684002: Remove unneeded definitions of O_BINARY (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by j.turney
Modified:
6 years, 3 months ago
Reviewers:
Ted Mielczarek, vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remove unneeded definitions of O_BINARY #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/dump_context.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/processor/minidump.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4
vapier
from what i can see, O_BINARY isn't used anywhere, so why don't we just delete ...
6 years, 3 months ago #1
j.turney
On 2015/01/27 13:44:54, vapier wrote: > from what i can see, O_BINARY isn't used anywhere, ...
6 years, 3 months ago #2
Ted Mielczarek
LGTM
6 years, 3 months ago #3
vapier
6 years, 3 months ago #4
i've committed this now in r1418 ... feel free to close :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted