Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 2824002: Microdumps: support aarch64 and lib mapping from APK (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by primiano
Modified:
6 years, 5 months ago
Reviewers:
mmandlis
CC:
google-breakpad-dev_googlegroups.com, Mark Mentovai
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Microdumps: support aarch64 and lib mapping from APK

- Filter modules by prot flags (only +x) not extensions. It wouldn't
  otherwise catch the case of Chrome mapping the library from the
  apk (which is mapped r-x but doesn't end in .so).
- Use compile-time detection of target arch, in order to cope with
  multilib OSes, where uname() doesn't reflect the run-time arch.
- Add OS information and CPU arch / count.
- Add support for aarch64.
- Add tests and stackwalk expectations for aarch64.
- Fix a potential overflow bug in the processor.
- Rebaseline the tests using smaller symbols.
- Fix microdump_writer_unittest.cc on 32-bit host.

BUG=chromium:410294

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Refactor common code in tests #

Patch Set 3 : Fix microdump_writer_unittest on 32 bit #

Patch Set 4 : Use AnalyzeDump in TestProcess_MissingSymbols #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/microdump_writer/microdump_writer.cc View 1 2 3 2 chunks +29 lines, -10 lines 0 comments Download
M src/client/linux/microdump_writer/microdump_writer_unittest.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/google_breakpad/processor/microdump.h View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M src/processor/microdump.cc View 1 2 3 5 chunks +49 lines, -5 lines 0 comments Download
M src/processor/microdump_processor.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/microdump_processor_unittest.cc View 1 2 3 3 chunks +54 lines, -37 lines 0 comments Download
M src/processor/microdump_stackwalk_machine_readable_test View 1 2 3 1 chunk +11 lines, -5 lines 0 comments Download
M src/processor/microdump_stackwalk_test View 1 2 3 1 chunk +11 lines, -5 lines 0 comments Download
A src/processor/microdump_stackwalk_test_vars View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A src/processor/testdata/microdump-arm.dmp View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump-arm64.dmp View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
D src/processor/testdata/microdump.dmp View 1 2 3 1 chunk +0 lines, -157 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk-arm.out View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk-arm64.out View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk.machine_readable-arm.out View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A src/processor/testdata/microdump.stackwalk.machine_readable-arm64.out View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
D src/processor/testdata/microdump.stackwalk.machine_readable.out View 1 2 3 1 chunk +0 lines, -129 lines 0 comments Download
D src/processor/testdata/microdump.stackwalk.out View 1 2 3 1 chunk +0 lines, -179 lines 0 comments Download

Messages

Total messages: 5
primiano
Hello! I got fixes for aarch64 (plus some minor improvements). Would you mind taking a ...
6 years, 5 months ago #1
mmandlis
please, address my comment before committing. lgtm https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc File src/processor/microdump_processor_unittest.cc (right): https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc#newcode181 src/processor/microdump_processor_unittest.cc:181: TEST_F(MicrodumpProcessorTest, TestProcessArm64) ...
6 years, 5 months ago #2
primiano
Done thanks. Will land this later next week. https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc File src/processor/microdump_processor_unittest.cc (right): https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc#newcode181 src/processor/microdump_processor_unittest.cc:181: TEST_F(MicrodumpProcessorTest, ...
6 years, 5 months ago #3
mmandlis
still lgtm. https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc File src/processor/microdump_processor_unittest.cc (right): https://breakpad.appspot.com/2824002/diff/50004/src/processor/microdump_processor_unittest.cc#newcode181 src/processor/microdump_processor_unittest.cc:181: TEST_F(MicrodumpProcessorTest, TestProcessArm64) { On 2014/11/28 18:32:38, primiano ...
6 years, 5 months ago #4
primiano
6 years, 5 months ago #5
Done.

Landed as r1407

(Also, yet again I used git svn dcommit instead of git cl dcommit, so the SVN
commit doesn't have the Review URL: ... my bad :/)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted