Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 587002: Use dynamic linker provided information to fill library mappings in linux minidumps, when possible

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by glandium
Modified:
2 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Use dynamic linker provided information to fill library mappings in linux
minidumps, when possible

Patch Set 1 #

Total comments: 3

Patch Set 2 : Refreshed with nits #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_dumper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 1 2 chunks +115 lines, -24 lines 0 comments Download

Messages

Total messages: 3
glandium
4 years ago #1
Ted Mielczarek
Just some nits. https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc File src/client/linux/minidump_writer/minidump_writer.cc (right): https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc#newcode901 src/client/linux/minidump_writer/minidump_writer.cc:901: dumper_->CopyFromProcess(&one_dyn, GetCrashThread(), dyn++, Google style frowns ...
3 years, 11 months ago #2
clairetom80
2 years, 2 months ago #3

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted