Issue 587002: Use dynamic linker provided information to fill library mappings in linux minidumps, when possible

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 587002: Use dynamic linker provided information to fill library mappings in linux minidumps, when possible

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by glandium

Modified:
9 years, 1 month ago

Reviewers:
Ted Mielczarek, clairetom80

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Use dynamic linker provided information to fill library mappings in linux
minidumps, when possible

Patch Set 2 : Refreshed with nits #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_dumper.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/client/linux/minidump_writer/minidump_writer.cc	View	1	2 chunks	+115 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

Just some nits. https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc File src/client/linux/minidump_writer/minidump_writer.cc (right): https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc#newcode901 src/client/linux/minidump_writer/minidump_writer.cc:901: dumper_->CopyFromProcess(&one_dyn, GetCrashThread(), dyn++, Google style frowns ...

10 years, 10 months ago #2

Expand All Messages | Collapse All Messages