Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
4694002	Win32 build fixes	zomps0	jturney	1	6 years, 6 months
3734002	Workaround WIN32 compile error C2039: '_exception_code' : is not a member of 'MDException'	zomps0			6 years, 6 months
6784002	MSVC 2013 build fix: error C2036: 'void *' : unknown size	zomps0			6 years, 6 months
6764002	Update breakpad to support Android NDK r10c (Closed)	fdegans	primiano, Mark Mentovai, rmcilroy	2	6 years, 6 months
6754003	Revert "Remove unecessary headers following NDK r10c update." (Closed)	primiano	rmcilroy, fdegans		6 years, 6 months
7734002	Refactor .so name detection logic in minidump/linux_dumper. (Closed)	primiano	Lei Zhang (chromium), mmandlis, Ted Mielczarek	12	6 years, 6 months
4684002	Microdumps: refactor out common parts of minidump_writer.cc (Closed)	primiano	Mark Mentovai, mmandlis	6	6 years, 7 months
6734002	Add inttypes for windows in dump_context (Closed)	mmandlis	primiano		6 years, 8 months
1134002	Ensure C:/Dumps/ exists in crash_generation_app (Closed)	j.turney	Ted Mielczarek		6 years, 10 months
2654002	Clean up common.gypi. (Closed)	chrisha	mmentovai, Mark Mentovai		7 years
1414002	Move build configuration to root of repository. (Closed)	chrisha	Mark Mentovai, ivanpe	7	7 years, 1 month
1304004	Update DEPS to bring in gtest, gmock and GYP. (Closed)	chrisha	Mark Mentovai, rsesek	15	7 years, 1 month
1314003	Add .gitignore file. (Closed)	chrisha	Mark Mentovai, rsesek	6	7 years, 1 month
1004002	Handle crashes caused by SIGSYS (e.g., due to SECCOMP_RET_TRAP). (Closed)	Jed Davis	Ted Mielczarek, Lei Zhang (chromium), jln		7 years, 3 months
824003	Conditionalize use of <cpuid.h> header (Closed)	Roland McGrath	Mark Mentovai		7 years, 5 months
864003	Use AM_MAINTAINER_MODE so configure supports --enable-maintainer-mode (Closed)	Roland McGrath	bradnelson, Mark Mentovai, Ted Mielczarek, mcgrathr		7 years, 5 months
704002	Process minidumps generated on ARM64 in iOS apps. (Closed)	blundell	Mark Mentovai, Ted Mielczarek	48	7 years, 5 months
774002	Re-enable ios_exception_minidump_generator being built on non-ARM. (Closed)	blundell	Mark Mentovai		7 years, 5 months
664002	Generate minidumps for 64-bit ARM apps on iOS. (Closed)	blundell	Mark Mentovai, qsr	93	7 years, 5 months
644002	Augment mach_vm_compat.h to support compiling for 64-bit on iOS. (Closed)	blundell	qsr		7 years, 5 months

Newer ›