Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 4694002: Win32 build fixes

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by zomps0
Modified:
6 years, 7 months ago
Reviewers:
jturney
Visibility:
Public.

Description

Win32 build fixes

Patch Set 1 #

Total comments: 1

Patch Set 2 : Win32 build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/disassembler_x86.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/processor/minidump_processor.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jturney
https://breakpad.appspot.com/4694002/diff/1/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): https://breakpad.appspot.com/4694002/diff/1/src/processor/minidump_processor.cc#newcode47 src/processor/minidump_processor.cc:47: #ifdef _WIN32 This should probably be conditional on _MSC_VER, ...
6 years, 7 months ago #1
zomps0
same solution is already used other files ./src/processor/logging.cc:#define snprintf _snprintf ./src/processor/minidump.cc:#define snprintf _snprintf ./src/processor/minidump_processor.cc:#define snprintf ...
6 years, 7 months ago #2
jturney
6 years, 7 months ago #3
On 2014/10/25 15:51:05, zomps0 wrote:
> same solution is already used other files
> ./src/processor/logging.cc:#define snprintf _snprintf
> ./src/processor/minidump.cc:#define snprintf _snprintf
> ./src/processor/minidump_processor.cc:#define snprintf _snprintf
> ....

It's wrong there also.

See https://breakpad.appspot.com/2734002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted