Issue 4694002: Win32 build fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 4694002: Win32 build fixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by zomps0

Modified:
9 years, 6 months ago

Reviewers:
jturney

Visibility:
Public.

More Reviews

Description

Win32 build fixes

Patch Set 2 : Win32 build fixes #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/processor/disassembler_x86.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/processor/minidump_processor.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jturney

https://breakpad.appspot.com/4694002/diff/1/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): https://breakpad.appspot.com/4694002/diff/1/src/processor/minidump_processor.cc#newcode47 src/processor/minidump_processor.cc:47: #ifdef _WIN32 This should probably be conditional on _MSC_VER, ...

9 years, 6 months ago #1

zomps0

same solution is already used other files ./src/processor/logging.cc:#define snprintf _snprintf ./src/processor/minidump.cc:#define snprintf _snprintf ./src/processor/minidump_processor.cc:#define snprintf ...

9 years, 6 months ago #2

jturney

9 years, 6 months ago #3

On 2014/10/25 15:51:05, zomps0 wrote:
> same solution is already used other files
> ./src/processor/logging.cc:#define snprintf _snprintf
> ./src/processor/minidump.cc:#define snprintf _snprintf
> ./src/processor/minidump_processor.cc:#define snprintf _snprintf
> ....

It's wrong there also.

See https://breakpad.appspot.com/2734002/

Expand All Messages | Collapse All Messages