Issue 6734002: Add inttypes for windows in dump_context (Closed)
DescriptionAdd inttypes for windows in dump_context BUG=https://code.google.com/p/google-breakpad/issues/detail?id=606 R=primiano@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1381 Patch Set 1 #Patch Set 2 : :q #
MessagesTotal messages: 7
My colleague verified that the build is now successful. However the tests fail. I doubt that it is related to my changes (yeah, I am always unreasonably optimistic), but haven't had the chance to verify it yet (I don't have a Windows box, so I'm dependent on other people running the tests for me). The test fails with the following message: Running main() from gmock_main.cc [==========] Running 36 tests from 7 test cases. [----------] Global test environment set-up. [----------] 8 tests from ExceptionHandlerDeathTest [ RUN ] ExceptionHandlerDeathTest.InProcTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.InProcTest (96 ms) [ RUN ] ExceptionHandlerDeathTest.OutOfProcTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.OutOfProcTest (83 ms) [ RUN ] ExceptionHandlerDeathTest.OutOfProcGuaranteedTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.OutOfProcGuaranteedTest (79 ms) [ RUN ] ExceptionHandlerDeathTest.InvalidParameterTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.InvalidParameterTest (88 ms) [ RUN ] ExceptionHandlerDeathTest.PureVirtualCallTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.PureVirtualCallTest (91 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemory Running main() from gmock_main.cc 2014-09-17 13:57:02: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemory\996881a7-22ec-4fe9-9e97-f971277dc627.dmp 2014-09-17 13:57:02: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:02: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemory (110 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound Running main() from gmock_main.cc 2014-09-17 13:57:02: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemoryMinBound\aeea073f-1e7c-44f0-9380-e6696280f458.dmp 2014-09-17 13:57:02: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:02: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound (107 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound Running main() from gmock_main.cc 2014-09-17 13:57:03: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemoryMaxBound\a9a1b117-ec9b-45ce-92b0-859570f4c337.dmp 2014-09-17 13:57:03: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:03: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound (104 ms) [----------] 8 tests from ExceptionHandlerDeathTest (763 ms total) [----------] 5 tests from ExceptionHandlerTest [ RUN ] ExceptionHandlerTest.InvalidParameterMiniDumpTest Running main() from gmock_main.cc exception_handler_test.cc(248): error: Value of: !dump_file.empty() && !full_dump_file.empty() Actual: false Expected: true [ FAILED ] ExceptionHandlerTest.InvalidParameterMiniDumpTest (47 ms) [ RUN ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest Running main() from gmock_main.cc exception_handler_test.cc(319): error: Value of: !dump_file.empty() && !full_dump_file.empty() Actual: false Expected: true [ FAILED ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest (45 ms) [ RUN ] ExceptionHandlerTest.WriteMinidumpTest 2014-09-17 13:57:03: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\WriteMinidumpTest\2dfcdfd4-8897-4af0-993b-677fc1ac08da.dmp 2014-09-17 13:57:03: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:03: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.WriteMinidumpTest (74 ms) [ RUN ] ExceptionHandlerTest.AdditionalMemory 2014-09-17 13:57:03: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\AdditionalMemory\7a1c10e6-66b6-4cd3-a854-20ae7094ba61.dmp 2014-09-17 13:57:03: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:03: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.AdditionalMemory (72 ms) [ RUN ] ExceptionHandlerTest.AdditionalMemoryRemove 2014-09-17 13:57:03: minidump.cc:4022: INFO: Minidump opened minidump C:\src\temp\AdditionalMemoryRemove\63be8a6f-a555-497d-be5e-b65ede6c0390.dmp 2014-09-17 13:57:03: minidump.cc:4139: INFO: Minidump not byte-swapping minidump 2014-09-17 13:57:03: minidump.cc:2830: INFO: MinidumpMemoryList has no memory region at 0x5e7710 2014-09-17 13:57:03: minidump.cc:3994: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.AdditionalMemoryRemove (75 ms) [----------] 5 tests from ExceptionHandlerTest (319 ms total) [----------] 2 tests from AssertDeathSanity [ RUN ] AssertDeathSanity.Simple Running main() from gmock_main.cc [ OK ] AssertDeathSanity.Simple (34 ms) [ RUN ] AssertDeathSanity.Regex Running main() from gmock_main.cc Running main() from gmock_main.cc [ OK ] AssertDeathSanity.Regex (69 ms) [----------] 2 tests from AssertDeathSanity (106 ms total) [----------] 6 tests from ExceptionHandlerCallbacks [ RUN ] ExceptionHandlerCallbacks.FilterTrue_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterTrue_No_Callback (88 ms) [ RUN ] ExceptionHandlerCallbacks.FilterTrue_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterTrue_Callback (90 ms) [ RUN ] ExceptionHandlerCallbacks.FilterFalse_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterFalse_No_Callback (40 ms) [ RUN ] ExceptionHandlerCallbacks.FilterFalse_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterFalse_Callback (40 ms) [ RUN ] ExceptionHandlerCallbacks.No_Filter_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.No_Filter_No_Callback (86 ms) [ RUN ] ExceptionHandlerCallbacks.No_Filter_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.No_Filter_Callback (94 ms) [----------] 6 tests from ExceptionHandlerCallbacks (445 ms total) [----------] 3 tests from ExceptionHandlerNesting [ RUN ] ExceptionHandlerNesting.Skip_From_Inner_Filter Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Skip_From_Inner_Filter (102 ms) [ RUN ] ExceptionHandlerNesting.Skip_From_Inner_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Skip_From_Inner_Callback (148 ms) [ RUN ] ExceptionHandlerNesting.Handled_By_Inner_Handler Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Handled_By_Inner_Handler (91 ms) [----------] 3 tests from ExceptionHandlerNesting (344 ms total) [----------] 5 tests from MinidumpTest [ RUN ] MinidumpTest.Version [ OK ] MinidumpTest.Version (5 ms) [ RUN ] MinidumpTest.Normal [ OK ] MinidumpTest.Normal (51 ms) [ RUN ] MinidumpTest.SmallDump [ OK ] MinidumpTest.SmallDump (56 ms) [ RUN ] MinidumpTest.LargerDump [ OK ] MinidumpTest.LargerDump (63 ms) [ RUN ] MinidumpTest.FullDump [ OK ] MinidumpTest.FullDump (243 ms) [----------] 5 tests from MinidumpTest (427 ms total) [----------] 7 tests from CrashGenerationServerTest [ RUN ] CrashGenerationServerTest.PingServerTest crash_generation_server_test.cc(118): error: Value of: WaitNamedPipe(kPipeName, 500) Actual: false Expected: true crash_generation_server_test.cc(142): error: Expected: FaultyClient(fault) doesn't generate new fatal failures in the current thread. Actual: it does. [ FAILED ] CrashGenerationServerTest.PingServerTest (2 ms) [ RUN ] CrashGenerationServerTest.InvalidRegistration [ OK ] CrashGenerationServerTest.InvalidRegistration (1 ms) [ RUN ] CrashGenerationServerTest.TruncateRegistration [ OK ] CrashGenerationServerTest.TruncateRegistration (1 ms) [ RUN ] CrashGenerationServerTest.CloseAfterRegistration [ OK ] CrashGenerationServerTest.CloseAfterRegistration (1 ms) [ RUN ] CrashGenerationServerTest.ResponseBufferTooSmall [ OK ] CrashGenerationServerTest.ResponseBufferTooSmall (1 ms) [ RUN ] CrashGenerationServerTest.CloseAfterResponse [ OK ] CrashGenerationServerTest.CloseAfterResponse (1 ms) [ RUN ] CrashGenerationServerTest.SendInvalidAck [ OK ] CrashGenerationServerTest.SendInvalidAck (0 ms) [----------] 7 tests from CrashGenerationServerTest (17 ms total) [----------] Global test environment tear-down [==========] 36 tests from 7 test cases ran. (2430 ms total) [ PASSED ] 33 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] ExceptionHandlerTest.InvalidParameterMiniDumpTest [ FAILED ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest [ FAILED ] CrashGenerationServerTest.PingServerTest 3 FAILED TESTS
Sign in to reply to this message.
So with r1369 only 2 tests fail (3 are failing with latest). CrashGenerationServerTest.PingServerTest is the only difference. Now it succeeds. Here is the complete log form the current run (I ran it twice to make sure there is no flakiness): Running main() from gmock_main.cc [==========] Running 36 tests from 7 test cases. [----------] Global test environment set-up. [----------] 8 tests from ExceptionHandlerDeathTest [ RUN ] ExceptionHandlerDeathTest.InProcTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.InProcTest (115 ms) [ RUN ] ExceptionHandlerDeathTest.OutOfProcTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.OutOfProcTest (87 ms) [ RUN ] ExceptionHandlerDeathTest.OutOfProcGuaranteedTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.OutOfProcGuaranteedTest (82 ms) [ RUN ] ExceptionHandlerDeathTest.InvalidParameterTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.InvalidParameterTest (93 ms) [ RUN ] ExceptionHandlerDeathTest.PureVirtualCallTest Running main() from gmock_main.cc [ OK ] ExceptionHandlerDeathTest.PureVirtualCallTest (95 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemory Running main() from gmock_main.cc 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemory\0da0ffb5-8176-482c-bf0c-f2b696fbbe66.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemory (125 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound Running main() from gmock_main.cc 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemoryMinBound\1b344a75-1ace-4a25-bbb8-a6dd547d533a.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound (129 ms) [ RUN ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound Running main() from gmock_main.cc 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\InstructionPointerMemoryMaxBound\caf1bc9d-983f-4fc0-90be-9bd34f9585d2.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound (117 ms) [----------] 8 tests from ExceptionHandlerDeathTest (851 ms total) [----------] 5 tests from ExceptionHandlerTest [ RUN ] ExceptionHandlerTest.InvalidParameterMiniDumpTest Running main() from gmock_main.cc exception_handler_test.cc(248): error: Value of: !dump_file.empty() && !full_dump_file.empty() Actual: false Expected: true [ FAILED ] ExceptionHandlerTest.InvalidParameterMiniDumpTest (47 ms) [ RUN ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest Running main() from gmock_main.cc exception_handler_test.cc(319): error: Value of: !dump_file.empty() && !full_dump_file.empty() Actual: false Expected: true [ FAILED ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest (48 ms) [ RUN ] ExceptionHandlerTest.WriteMinidumpTest 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\WriteMinidumpTest\59ccb07e-ce8d-46cf-b1a1-90595563933e.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.WriteMinidumpTest (87 ms) [ RUN ] ExceptionHandlerTest.AdditionalMemory 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\AdditionalMemory\70307316-1386-4b90-9b8f-e130d043f5e9.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.AdditionalMemory (90 ms) [ RUN ] ExceptionHandlerTest.AdditionalMemoryRemove 2014-09-17 17:42:47: minidump.cc:4546: INFO: Minidump opened minidump C:\src\temp\AdditionalMemoryRemove\32da6c98-ceed-4377-9be3-1b551f964974.dmp 2014-09-17 17:42:47: minidump.cc:4663: INFO: Minidump not byte-swapping minidump 2014-09-17 17:42:47: minidump.cc:3354: INFO: MinidumpMemoryList has no memory region at 0x497710 2014-09-17 17:42:47: minidump.cc:4518: INFO: Minidump closing minidump [ OK ] ExceptionHandlerTest.AdditionalMemoryRemove (99 ms) [----------] 5 tests from ExceptionHandlerTest (378 ms total) [----------] 2 tests from AssertDeathSanity [ RUN ] AssertDeathSanity.Simple Running main() from gmock_main.cc [ OK ] AssertDeathSanity.Simple (33 ms) [ RUN ] AssertDeathSanity.Regex Running main() from gmock_main.cc Running main() from gmock_main.cc [ OK ] AssertDeathSanity.Regex (69 ms) [----------] 2 tests from AssertDeathSanity (110 ms total) [----------] 6 tests from ExceptionHandlerCallbacks [ RUN ] ExceptionHandlerCallbacks.FilterTrue_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterTrue_No_Callback (94 ms) [ RUN ] ExceptionHandlerCallbacks.FilterTrue_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterTrue_Callback (103 ms) [ RUN ] ExceptionHandlerCallbacks.FilterFalse_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterFalse_No_Callback (40 ms) [ RUN ] ExceptionHandlerCallbacks.FilterFalse_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.FilterFalse_Callback (38 ms) [ RUN ] ExceptionHandlerCallbacks.No_Filter_No_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.No_Filter_No_Callback (94 ms) [ RUN ] ExceptionHandlerCallbacks.No_Filter_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerCallbacks.No_Filter_Callback (94 ms) [----------] 6 tests from ExceptionHandlerCallbacks (473 ms total) [----------] 3 tests from ExceptionHandlerNesting [ RUN ] ExceptionHandlerNesting.Skip_From_Inner_Filter Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Skip_From_Inner_Filter (100 ms) [ RUN ] ExceptionHandlerNesting.Skip_From_Inner_Callback Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Skip_From_Inner_Callback (147 ms) [ RUN ] ExceptionHandlerNesting.Handled_By_Inner_Handler Running main() from gmock_main.cc [ OK ] ExceptionHandlerNesting.Handled_By_Inner_Handler (109 ms) [----------] 3 tests from ExceptionHandlerNesting (360 ms total) [----------] 5 tests from MinidumpTest [ RUN ] MinidumpTest.Version [ OK ] MinidumpTest.Version (5 ms) [ RUN ] MinidumpTest.Normal [ OK ] MinidumpTest.Normal (55 ms) [ RUN ] MinidumpTest.SmallDump [ OK ] MinidumpTest.SmallDump (68 ms) [ RUN ] MinidumpTest.LargerDump [ OK ] MinidumpTest.LargerDump (68 ms) [ RUN ] MinidumpTest.FullDump [ OK ] MinidumpTest.FullDump (222 ms) [----------] 5 tests from MinidumpTest (432 ms total) [----------] 7 tests from CrashGenerationServerTest [ RUN ] CrashGenerationServerTest.PingServerTest [ OK ] CrashGenerationServerTest.PingServerTest (1 ms) [ RUN ] CrashGenerationServerTest.InvalidRegistration [ OK ] CrashGenerationServerTest.InvalidRegistration (11 ms) [ RUN ] CrashGenerationServerTest.TruncateRegistration [ OK ] CrashGenerationServerTest.TruncateRegistration (1 ms) [ RUN ] CrashGenerationServerTest.CloseAfterRegistration [ OK ] CrashGenerationServerTest.CloseAfterRegistration (1 ms) [ RUN ] CrashGenerationServerTest.ResponseBufferTooSmall [ OK ] CrashGenerationServerTest.ResponseBufferTooSmall (11 ms) [ RUN ] CrashGenerationServerTest.CloseAfterResponse [ OK ] CrashGenerationServerTest.CloseAfterResponse (2 ms) [ RUN ] CrashGenerationServerTest.SendInvalidAck [ OK ] CrashGenerationServerTest.SendInvalidAck (1 ms) [----------] 7 tests from CrashGenerationServerTest (54 ms total) [----------] Global test environment tear-down [==========] 36 tests from 7 test cases ran. (2680 ms total) [ PASSED ] 34 tests.
Sign in to reply to this message.
I don't see any recent changes that might have caused this change. Let me know if you have an idea, otherwise I'll look into it tomorrow. Thanks.
Sign in to reply to this message.
LGTM. I think you can also remove these lines from minidump.cc as the code it was referring to them is the one you movede here (but please double check). Not a lot of clues for the tests. I just don't understand the history. If you sync previous to your changes (say r1368) does it still fail?
Sign in to reply to this message.
minidump still uses PRIx64 and snprintf. so the only one I could actually remove is PRIx32. should i? On 2014/09/18 09:52:11, primiano wrote: > LGTM. > I think you can also remove these lines from minidump.cc as the code it was > referring to them is the one you movede here (but please double check). > Not a lot of clues for the tests. I just don't understand the history. > If you sync previous to your changes (say r1368) does it still fail?
Sign in to reply to this message.
On 2014/09/18 17:01:02, mmandlis wrote: > minidump still uses PRIx64 and snprintf. > > so the only one I could actually remove is PRIx32. should i? > > On 2014/09/18 09:52:11, primiano wrote: > > LGTM. > > I think you can also remove these lines from minidump.cc as the code it was > > referring to them is the one you movede here (but please double check). > > Not a lot of clues for the tests. I just don't understand the history. > > If you sync previous to your changes (say r1368) does it still fail? Ah I didn't realize. In that case don't bother.
Sign in to reply to this message.
|
|||||||||||||||||||||||||||||||||||||||||||
