Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(645)

Issue 1414002: Move build configuration to root of repository. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by chrisha
Modified:
9 years, 11 months ago
Reviewers:
Mark Mentovai, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Move build configuration to root of repository.

This is in preparation for creating GYP build files for each platform.

BUG=https://code.google.com/p/google-breakpad/issues/detail?id=575
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1304

Patch Set 1 : #

Total comments: 7

Patch Set 2 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M .gitignore View 1 2 chunks +2 lines, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + build/common.gypi View 1 2 chunks +1 line, -8 lines 0 comments Download
A + build/external_code.gypi View 1 2 chunks +1 line, -8 lines 0 comments Download
A + build/internal/release_defaults.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/internal/release_impl.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/internal/release_impl_official.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/release.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/client/windows/breakpad_client.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
D src/client/windows/build/common.gypi View 1 chunk +0 lines, -1332 lines 0 comments Download
D src/client/windows/build/external_code.gypi View 1 chunk +0 lines, -71 lines 0 comments Download
D src/client/windows/build/internal/release_defaults.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D src/client/windows/build/internal/release_impl.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D src/client/windows/build/internal/release_impl_official.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D src/client/windows/build/release.gypi View 1 chunk +0 lines, -19 lines 0 comments Download
M src/client/windows/crash_generation/crash_generation.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/client/windows/handler/exception_handler.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/client/windows/sender/crash_report_sender.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/client/windows/tests/crash_generation_app/crash_generation_app.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/client/windows/unittests/client_tests.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/client/windows/unittests/testing.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/common/windows/common_windows.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/tools/windows/dump_syms/dump_syms.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/tools/windows/symupload/symupload.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10
chrisha
PTAL
9 years, 12 months ago #1
Mark Mentovai
https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi File build/common.gypi (right): https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi#newcode1326 build/common.gypi:1326: Get rid of the blank line at the end ...
9 years, 12 months ago #2
chrisha
This CL simply moves the existing 'build' directory. While I agree that common.gypi and its ...
9 years, 12 months ago #3
Mark Mentovai
> I'd argue for keeping a Debug build profile as well, however. The symbol > ...
9 years, 12 months ago #4
chrisha
On 2014/04/03 18:28:10, Mark Mentovai wrote: > > I'd argue for keeping a Debug build ...
9 years, 12 months ago #5
chrisha
Committed patchset #2 manually as r1304 (presubmit successful).
9 years, 12 months ago #6
ivanpe
On 2014/04/03 18:35:10, chrisha wrote: > Committed patchset #2 manually as r1304 (presubmit successful). Chris, ...
9 years, 11 months ago #7
ivanpe
On 2014/04/09 22:31:19, ivanpe wrote: > On 2014/04/03 18:35:10, chrisha wrote: > > Committed patchset ...
9 years, 11 months ago #8
Mark Mentovai
Leave the BUILD file alone and move the build directory.
9 years, 11 months ago #9
ivanpe
9 years, 11 months ago #10
Message was sent while issue was closed.
On 2014/04/09 23:47:56, Mark Mentovai wrote:
> Leave the BUILD file alone and move the build directory.

Sounds good.  I'll send a CL shortly.  Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted