Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 2654002: Clean up common.gypi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by chrisha
Modified:
9 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Clean up common.gypi.

This removes a handful of redundant variables and GYP includes.

BUG=
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/build/common.gypi View 11 chunks +55 lines, -232 lines 0 comments Download
D src/build/external_code.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D src/build/internal/release_defaults.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D src/build/internal/release_impl.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D src/build/internal/release_impl_official.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D src/build/release.gypi View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4
chrisha
PTAL
9 years, 11 months ago #1
Mark Mentovai
This is much better, LGTM.
9 years, 11 months ago #2
chrisha
Thanks, committing.
9 years, 11 months ago #3
chrisha
9 years, 11 months ago #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1321 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted