Issue 644002: Augment mach_vm_compat.h to support compiling for 64-bit on iOS.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 644002: Augment mach_vm_compat.h to support compiling for 64-bit on iOS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by blundell

Modified:
10 years, 5 months ago

Reviewers:
qsr

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Augment mach_vm_compat.h to support compiling for 64-bit on iOS.

When compiling for 64-bit on iOS, the vm_map function vm_region_recurse_64 must
be used in place of vm_region_recurse.

Patch by blundell@chromium.org

BUG=542

Patch Set 2 : Remove unwanted changes #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/mac/handler/mach_vm_compat.h	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

blundell

The usage of __LP64__ comes from https://developer.apple.com/library/ios/documentation/General/Conceptual/CocoaTouch64BitGuide/Major64-BitChanges/Major64-BitChanges.html#//apple_ref/doc/uid/TP40013501-CH2-SW1.

10 years, 6 months ago #1

qsr

It seems that vm_region_recurse and vm_region_recurse_64 do not take exactly the same parameters (vm_region_info_t vs ...

10 years, 6 months ago #2

Folding this change into https://breakpad.appspot.com/664002/, closing this
issue.

Expand All Messages | Collapse All Messages