Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8681)

Issue 664002: Generate minidumps for 64-bit ARM apps on iOS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by blundell
Modified:
10 years, 4 months ago
Reviewers:
Mark Mentovai, qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Generate minidumps for 64-bit ARM apps on iOS.

Adds an ARM64-specific definition of MDRawContext and support for writing out a
minidump when running on ARM64. Additionally, extends the iOS minidump generator
for NSExceptions to work on ARM64 as well as ARM.

Patch Set 1 #

Patch Set 2 : Remove debugging output #

Patch Set 3 : Nit #

Total comments: 14

Patch Set 4 : Fixes #

Total comments: 63

Patch Set 5 : Response to review #

Total comments: 14

Patch Set 6 : Respond to review #

Total comments: 2

Patch Set 7 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/ios/Breakpad.xcodeproj/project.pbxproj View 1 2 3 4 9 chunks +12 lines, -4 lines 0 comments Download
M src/client/ios/handler/ios_exception_minidump_generator.h View 1 2 3 4 1 chunk +9 lines, -2 lines 0 comments Download
M src/client/ios/handler/ios_exception_minidump_generator.mm View 1 2 3 4 5 5 chunks +61 lines, -33 lines 0 comments Download
M src/client/mac/handler/dynamic_images.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/client/mac/handler/exception_handler.cc View 1 2 3 4 5 6 5 chunks +13 lines, -11 lines 0 comments Download
M src/client/mac/handler/exception_handler.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/client/mac/handler/mach_vm_compat.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/client/mac/handler/minidump_generator.cc View 1 2 3 4 5 10 chunks +111 lines, -6 lines 0 comments Download
M src/client/mac/handler/minidump_generator.h View 1 2 3 4 5 chunks +13 lines, -3 lines 0 comments Download
A + src/client/mac/handler/ucontext_compat.h View 1 2 3 4 5 6 2 chunks +15 lines, -24 lines 0 comments Download
A + src/google_breakpad/common/minidump_cpu_arm64.h View 1 2 3 4 5 3 chunks +43 lines, -54 lines 0 comments Download
M src/google_breakpad/common/minidump_format.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11
blundell
Hi Mark and Ben, With the changes in this CL, I am now generating minidumpson ...
10 years, 5 months ago #1
qsr
https://breakpad.appspot.com/664002/diff/30001/src/client/mac/handler/minidump_generator.cc File src/client/mac/handler/minidump_generator.cc (right): https://breakpad.appspot.com/664002/diff/30001/src/client/mac/handler/minidump_generator.cc#newcode569 src/client/mac/handler/minidump_generator.cc:569: #undef AddReg AddReg was never defined, you can remove ...
10 years, 5 months ago #2
blundell
Hi Mark, Ben is OOO for the next couple weeks; could you take over this ...
10 years, 4 months ago #3
Mark Mentovai
blundell@chromium.org wrote: > Ben is OOO for the next couple weeks; could you take over ...
10 years, 4 months ago #4
Mark Mentovai
https://breakpad.appspot.com/664002/diff/250001/src/client/ios/Breakpad.xcodeproj/project.pbxproj File src/client/ios/Breakpad.xcodeproj/project.pbxproj (right): https://breakpad.appspot.com/664002/diff/250001/src/client/ios/Breakpad.xcodeproj/project.pbxproj#newcode1 src/client/ios/Breakpad.xcodeproj/project.pbxproj:1: // !$*UTF8*$! I guess this file lists nearby headers. ...
10 years, 4 months ago #5
blundell
Hi Mark, Thanks! All comments addressed. I'm working my way through the list of crashes ...
10 years, 4 months ago #6
Mark Mentovai
https://breakpad.appspot.com/664002/diff/250001/src/client/ios/handler/ios_exception_minidump_generator.mm File src/client/ios/handler/ios_exception_minidump_generator.mm (right): https://breakpad.appspot.com/664002/diff/250001/src/client/ios/handler/ios_exception_minidump_generator.mm#newcode171 src/client/ios/handler/ios_exception_minidump_generator.mm:171: size_t data_size = sizeof(long); blundell wrote: > It's the ...
10 years, 4 months ago #7
blundell
Thanks for the review! https://breakpad.appspot.com/664002/diff/250001/src/client/ios/handler/ios_exception_minidump_generator.mm File src/client/ios/handler/ios_exception_minidump_generator.mm (right): https://breakpad.appspot.com/664002/diff/250001/src/client/ios/handler/ios_exception_minidump_generator.mm#newcode176 src/client/ios/handler/ios_exception_minidump_generator.mm:176: scoped_array<uint8_t> stack_memory(new uint8_t[stack_size]); Filed https://code.google.com/p/google-breakpad/issues/detail?id=548. ...
10 years, 4 months ago #8
Mark Mentovai
I will LG this once we decide how to deal with the MACH_EXCEPTION_CODES thing. Awaiting ...
10 years, 4 months ago #9
blundell
Thanks! I can't land this myself, BTW. https://breakpad.appspot.com/664002/diff/420002/src/client/mac/handler/exception_handler.cc File src/client/mac/handler/exception_handler.cc (right): https://breakpad.appspot.com/664002/diff/420002/src/client/mac/handler/exception_handler.cc#newcode459 src/client/mac/handler/exception_handler.cc:459: switch (target_behavior ...
10 years, 4 months ago #10
Mark Mentovai
10 years, 4 months ago #11
Committed Breakpad r1235.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted