Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

Issue 824003: Conditionalize use of <cpuid.h> header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Roland McGrath
Modified:
10 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Conditionalize use of <cpuid.h> header

This header only exists for x86 environments, but was included
unconditionally.  That broke the builds for all non-x86 environments.

R=mark@chromium.org
BUG=

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1253

Patch Set 1 #

Patch Set 2 : Conditionalize use of <cpuid.h> header #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_ptrace_dumper.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6
Roland McGrath
10 years, 4 months ago #1
Mark Mentovai
LGTM. The use of cpuid is wrong, anyway. See https://breakpad.appspot.com/834003/ , which fixes it. If ...
10 years, 4 months ago #2
Roland McGrath
On 2013/12/10 18:02:29, Mark Mentovai wrote: > LGTM. > > The use of cpuid is ...
10 years, 4 months ago #3
Mark Mentovai
That works for me.
10 years, 4 months ago #4
Roland McGrath
Conditionalize use of <cpuid.h> header This header only exists for x86 environments, but was included ...
10 years, 4 months ago #5
Roland McGrath
10 years, 4 months ago #6
Message was sent while issue was closed.
Committed patchset #2 manually as r1253 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted