Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
1664002	Add support for CFI based stack walking on Arm64. (Closed)	rmcilroy	Mark Mentovai, blundell	4	11 years, 2 months
1654002	Add Arm64 support to dumpsyms. (Closed)	rmcilroy	Mark Mentovai, blundell		11 years, 2 months
1624003	Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped. (Closed)	rmcilroy	Lei Zhang (chromium)		11 years, 2 months
1214002	minidump-2-core: Allow user to override shared lib basedir.	kouhei	Lei Zhang (chromium)	1	11 years, 2 months
1464002	Fill in CPU info in mini-dump for Arm64. (Closed)	rmcilroy	Mark Mentovai	9	11 years, 2 months
1524002	[Android]: Fix hang in CreateChildCrash() on Android. (Closed)	rmcilroy	Lei Zhang (chromium), vapier	2	11 years, 2 months
1544002	x64: Update offset of fpregs_mem. (Closed)	anton	Lei Zhang (chromium), rmcilroy		11 years, 2 months
1534002	Update offset of fpregs_mem.	anton			11 years, 3 months
1454002	Add x64 version of getcontext. (Closed)	anton	Lei Zhang (chromium), dannyb, rmcilroy	10	11 years, 3 months
1484002	Increase Breakpad's signal handler stack size. (Closed)	rmcilroy	Mark Mentovai		11 years, 3 months
1444002	Fix aarch64 ucontext layout on Android (Closed)	rmcilroy	Mark Mentovai		11 years, 3 months
1424002	Add Arm64 support to breakpad unittests. (Closed)	rmcilroy	Mark Mentovai	2	11 years, 3 months
1384002	Add Arm64 version of breakpad_getcontext for Android. (Closed)	rmcilroy	Mark Mentovai	11	11 years, 3 months
1354002	First cut at adding arm64 Linux / Android support to Breakpad. (Closed)	rmcilroy	Mark Mentovai	13	11 years, 3 months
1374002	Remove some unecessary Android system header definitions. (Closed)	rmcilroy	Mark Mentovai	2	11 years, 3 months
1304002	Make ARM64 detection consistent in chromium.	primiano	Mark Mentovai, blundell		11 years, 3 months
1224002	64bit PDB format (Closed)	Will Harris			11 years, 3 months
904002	Add -[BreakpadController resetConfiguration] for iOS. (Closed)	kiyun	blundell	4	11 years, 7 months
714002	Provide BreakpadGetCrashReportCount() and -[BreakpadController getCrashReportCount:] (Closed)	kiyun	Mark Mentovai, qsr		11 years, 7 months
639002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		11 years, 9 months

Newer ›